Attempt to fix timing test CI failure. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michael-grunder
commented
Aug 12, 2024
•
michael-grunder
commented
- Reduce sleep time from 3s to 1s. No need to sleep so long.
- Relax tolerances so we can be pretty sure the server has awakened when we make the next attempt.
michael-grunder
force-pushed
the
fix-timing-test
branch
2 times, most recently
from
f5fab5a to
e352bb8
Compare
bjosv
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Great finding.
I ran the target separately and your change seems to fix it.
When running the tests 20 times in a row, within the same job, it failed 10 of 20 without the change.
With this fix it failed 1 of 20. This is good enough, but extending the time just a bit more to 1.5s would be ok for me. Then it was 0 of 20 fails when I ran a couple of times.
* Reduce sleep time from 3s to 1s. No need to sleep so long. * Sleep for additional time to account for timing/preemption issues in the CI runner. Signed-off-by: michael-grunder <[email protected]>
michael-grunder
force-pushed
the
fix-timing-test
branch
from
e352bb8 to
d235624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.