Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added available installation options #223

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Added available installation options #223

merged 7 commits into from
Feb 5, 2025

Conversation

avifenesh
Copy link
Member

@avifenesh avifenesh commented Feb 4, 2025 •
edited by zuiderkwast
Loading

@avifenesh avifenesh mentioned this pull request Feb 4, 2025
Merged
1 task
@avifenesh
Copy link
Member Author

@madolson @zuiderkwast Please review

zuiderkwast
zuiderkwast reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Just some minor comments.

topics/installation.md Outdated Show resolved Hide resolved
topics/installation.md Outdated Show resolved Hide resolved
topics/installation.md Show resolved Hide resolved
zuiderkwast
zuiderkwast reviewed Feb 4, 2025
View reviewed changes
topics/installation.md Outdated Show resolved Hide resolved
madolson added a commit to valkey-io/valkey-io.github.io that referenced this pull request Feb 4, 2025
@avifenesh @madolson
Add installation link to download (#202)
6aabd68 
### Description

<!-- Describe what this change achieves-->
 
### Issues Resolved
Issue valkey-io/valkey-doc#221
Rebased over #201
Related PR: valkey-io/valkey-doc#223

Changes looks:


![image](https://github.com/user-attachments/assets/694f9b8c-3dd7-4c34-a9d7-9d1dd67d4a33)


![image](https://github.com/user-attachments/assets/3aeee441-f759-42d2-812d-dc8e95515ecb)

### Check List
- [x] Commits are signed per the DCO using `--signoff`

By submitting this pull request, I confirm that my contribution is made
under the terms of the BSD-3-Clause License.

---------

Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: avifenesh <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
Co-authored-by: avifenesh <[email protected]>
madolson
madolson reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm.

topics/installation.md Outdated Show resolved Hide resolved
topics/installation.md Outdated Show resolved Hide resolved
topics/installation.md Outdated Show resolved Hide resolved
@avifenesh
Copy link
Member Author

@zuiderkwast @madolson Updated

madolson
madolson approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@madolson madolson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a comment, but I am OK with the latest version. Will let Viktor weigh in as well. Once this is merged I'll trigger a website update.

changed support disclusore
79d0fc8 
Signed-off-by: avifenesh <[email protected]>
@avifenesh
Copy link
Member Author

Made a comment, but I am OK with the latest version. Will let Viktor weigh in as well. Once this is merged I'll trigger a website update.

Done.

zuiderkwast
zuiderkwast approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

There are some other formatting changes. I didn't test render it, but I hope you did and checked that they render OK.

@zuiderkwast zuiderkwast changed the title Added avilable instalation options Added available installation options Feb 5, 2025
zuiderkwast
zuiderkwast reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing that would be nice to mention: valkey-doc exists at least on Fedora and it gives you man pages for all Valkey commands. We could list it as an optional step.

If you want, you could check if this exists on other package managers too...

added valkey-doc
6b51a99 
Signed-off-by: avifenesh <[email protected]>
@avifenesh
Copy link
Member Author

avifenesh commented Feb 5, 2025 •
edited
Loading

Ok did the comparison, the indent doesn't change the look, its just md standards.
added valkey-doc to fedora. Its doesn't exist on ubuntu or brew. for the other, i will leave it for another iteration.
So you can merge it
(I can't)
@zuiderkwast @madolson

zuiderkwast
zuiderkwast reviewed Feb 5, 2025
View reviewed changes
topics/installation.md Outdated Show resolved Hide resolved
zuiderkwast
zuiderkwast reviewed Feb 5, 2025
View reviewed changes
topics/installation.md Outdated Show resolved Hide resolved
avifenesh and others added 2 commits February 5, 2025 20:12
@avifenesh @zuiderkwast
Update topics/installation.md
6686b98 
Co-authored-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Avi Fenesh <[email protected]>
@avifenesh @zuiderkwast
Update topics/installation.md
24bd4c1 
Co-authored-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Avi Fenesh <[email protected]>
@zuiderkwast zuiderkwast merged commit e68f72b into valkey-io:main Feb 5, 2025
2 checks passed
@avifenesh avifenesh deleted the how-install branch February 5, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

@madolson madolson madolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Installation - Supported in almost all distros PM, page should be updated.
3 participants
@avifenesh @zuiderkwast @madolson