Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
Fix up merge duplication and use HScanOptions constants.
  • Loading branch information
jduo committed Jun 29, 2024
1 parent f1429ac commit b959c6c
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions java/client/src/test/java/glide/api/models/TransactionTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -1372,17 +1372,20 @@ InfScoreBound.NEGATIVE_INFINITY, new ScoreBoundary(3, false), new Limit(1, 2)),
ZScanOptions.COUNT_OPTION_STRING,
"10")));

transaction.zscan("key1", "0");
results.add(Pair.of(ZScan, buildArgs("key1", "0")));

transaction.zscan("key1", "0", ZScanOptions.builder().matchPattern("*").count(10L).build());
results.add(Pair.of(ZScan, buildArgs("key1", "0", "MATCH", "*", "COUNT", "10")));

transaction.hscan("key1", "0");
results.add(Pair.of(HScan, buildArgs("key1", "0")));

transaction.hscan("key1", "0", HScanOptions.builder().matchPattern("*").count(10L).build());
results.add(Pair.of(HScan, buildArgs("key1", "0", "MATCH", "*", "COUNT", "10")));
results.add(
Pair.of(
HScan,
buildArgs(
"key1",
"0",
HScanOptions.MATCH_OPTION_STRING,
"*",
HScanOptions.COUNT_OPTION_STRING,
"10")));

var protobufTransaction = transaction.getProtobufTransaction().build();

Expand Down

0 comments on commit b959c6c

Please sign in to comment.