Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased Python & Node MacOS github actions timeout #1126

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

barshaul
Copy link
Collaborator

@barshaul barshaul commented Mar 15, 2024

Due to recent fixes #1094 #1098 in MacOS CI in node and python the overall CI time was increased.

@barshaul barshaul requested a review from a team as a code owner March 15, 2024 16:03
@barshaul barshaul requested a review from shachlanAmazon March 15, 2024 16:04
@barshaul barshaul force-pushed the increase_macos_timeout branch from 9d7ab5d to 70aa4e3 Compare March 15, 2024 16:07
Copy link
Contributor

@shachlanAmazon shachlanAmazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should split large actions (e.g. npm run $BUILD_FLAG --build-flags="$TARGET_FLAG") into smaller actions, in order to have a better understanding of what takes so long.

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definetly use cache to avoid re-building glide core for every PR/push
This will speed up the build process.

See #771

@barshaul
Copy link
Collaborator Author

We should definetly use cache to avoid re-building glide core for every PR/push This will speed up the build process.

See #771

Agreed, can be done in a different PR

@barshaul barshaul merged commit f72f39d into valkey-io:main Mar 19, 2024
15 checks passed
@Yury-Fridlyand Yury-Fridlyand added the CI/CD CI/CD related label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants