Python: command WAIT #1710
Python: command WAIT #1710
Conversation
tjzhang-BQ
force-pushed
the
python/integ_tjz_wait
branch
2 times, most recently
from
307c4df to
cea8126
Compare
|
Please apply my comments from #1707 here too |
tjzhang-BQ
force-pushed
the
python/integ_tjz_wait
branch
from
9cd5a54 to
2701cce
Compare
| # ensure that command doesn't time out even if timeout > request timeout (250ms by default) | ||
| assert await redis_client.set(key, value2) == OK | ||
| assert await redis_client.wait(100, 500) >= 0 | ||
|
|
There was a problem hiding this comment.
Should we add the following tests that also exist on the Java side?
- wrap a WAIT call with numreplicas=100 and timeout=0 in a task, ensure it raises a TimeoutError
- pass negative timeout value, ensure an error occurs
There was a problem hiding this comment.
added bad input test, the other test mainly checks that the command wouldnt time itself out even if the timeout is above the client request timeout, to reflect this setting from glide core, which getting a result from that line should suffice.
There was a problem hiding this comment.
Yeah I guess it also tests the no-timeout functionality but maybe that's not necessary really
| assert await redis_client.wait(1, 1000) >= 1 | ||
| else: | ||
| assert await redis_client.wait(1, 1000) >= 0 |
There was a problem hiding this comment.
Would it be better to use == instead of >= since that's what we have in Java?
| assert await redis_client.wait(1, 1000) >= 1 | |
| else: | |
| assert await redis_client.wait(1, 1000) >= 0 | |
| assert await redis_client.wait(1, 1000) == 1 | |
| else: | |
| assert await redis_client.wait(1, 1000) == 0 |
| # ensure that command doesn't time out even if timeout > request timeout (250ms by default) | ||
| assert await redis_client.set(key, value2) == OK | ||
| assert await redis_client.wait(100, 500) >= 0 | ||
|
|
There was a problem hiding this comment.
Yeah I guess it also tests the no-timeout functionality but maybe that's not necessary really
* Python: command WAIT * Python: command WAIT * changelog * doc & test changes * linter * doc update * update example * addressing commends rd2 --------- Co-authored-by: TJ Zhang <[email protected]>
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.