Test all Python versions #1758
Test all Python versions #1758
Conversation
barshaul
force-pushed
the
test_all_py_vers
branch
7 times, most recently
from
a0cf49a to
3e37e94
Compare
| @@ -626,8 +626,6 @@ async def transaction_test( | |||
| args.append(b"one") | |||
| transaction.srandmember_count(key7, 1) | |||
| args.append([b"one"]) | |||
| transaction.wait(1, 1000) | |||
There was a problem hiding this comment.
I wrote in the description but i'll elaborate about the reason - "wait" has a flakey response in its nature as it requires the replicas to respond to the server in the specified timeout duration. If the replicas doesn't get to answer in time - which can happen in an integration test environment, we wouldn't get the expected result. The test already expect not to get a the replica to respond in time (expected value is 0), but we see in some tests that the return value is 1 meaning that the replica was able to response in the specified time. So we see some flakeyness where the return value is 1 instead of 0. This command shouldn't be tested inside of the long transaction test as it makes the whole test flakey.
barshaul
force-pushed
the
test_all_py_vers
branch
from
3e37e94 to
f14c7a2
Compare
barshaul
force-pushed
the
test_all_py_vers
branch
from
5d2c56f to
c08f8ba
Compare
| - "3.8" | ||
| - "3.9" |
There was a problem hiding this comment.
So, do we support 3.8 and 3.9 or not?
I still hear differnt gossips even now, after this PR merged.
|
|
||
| GLIDE for Redis is API-compatible with open source Redis version 6 and 7. | ||
| Refer to the [Supported Engine Versions table](https://github.com/aws/glide-for-redis/blob/main/README.md#supported-engine-versions) for details. |
There was a problem hiding this comment.
This should be a relative link to avoid branch like 2.x poiting to main
|
|
||
| Python 3.8 or higher. | ||
| | Python Version | |
There was a problem hiding this comment.
Should we have similar for node, java and c#?
| @@ -371,7 +371,7 @@ def _create_geosearch_args( | |||
| store_dist: bool = False, | |||
| ) -> List[TEncodable]: | |||
| args: List[TEncodable] = keys | |||
| if isinstance(search_from, str | bytes): | |||
| if isinstance(search_from, (str, bytes)): | |||
There was a problem hiding this comment.
search_from should be TEncodable.
| from datetime import date, datetime, timedelta, timezone | ||
| from typing import Any, Dict, List, Tuple, Union, cast | ||
| from typing import Any, Dict, List, Mapping, Tuple, Union, cast |
There was a problem hiding this comment.
Should we stop using Mapping of favour of Dict?
| @@ -388,7 +388,7 @@ async def transaction_test( | |||
| args.append(False) | |||
|
|
|||
| transaction.zadd(key8, {"one": 1, "two": 2, "three": 3, "four": 4}) | |||
| args.append(4) | |||
| args.append(4.0) | |||
There was a problem hiding this comment.
How it worked before?
| @@ -471,16 +471,16 @@ async def transaction_test( | |||
| args.append(3) | |||
| transaction.zinter([key14, key15]) | |||
| args.append([b"one", b"two"]) | |||
| transaction.zinter_withscores(cast(list[str | bytes], [key14, key15])) | |||
| transaction.zinter_withscores(cast(List[Union[str, bytes]], [key14, key15])) | |||
* Fixed Supported Engine Versions in all readmes * Python lint: Exclude submodules folder from mypy * Python CI: Added tests to all supported python versions and fixed tests accordingly * Removed flakey "wait" test from transaction, changes ints to doubles * Exclude pubsub tests as a temp solution
This PR includes the following changes:
Fixed Supported Engine Versions in Readmes:
Python Linting:
submodulesfolder frommypychecks. We shouldn't run linters on external repositories.Python CI Enhancements:
Bug Fixes and Improvements:
pubsubtests as a workaround for the flakey tests, until the flakiness will be resolved.