Java: type migration for entries_read #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzhang-BQ
added
python
tjzhang-BQ
changed the title
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
approved these changes
Jul 2, 2024
jduo
reviewed
Jul 2, 2024
jduo
reviewed
Jul 2, 2024
java/client/src/main/java/glide/api/models/commands/stream/StreamGroupOptions.java
Outdated
Show resolved
Hide resolved
tjzhang-BQ
force-pushed
the
java/python/integ_tjz_entriesread
branch
from
dd62b91 to
656cb0a
Compare
aaron-congo
approved these changes
Jul 3, 2024
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Aaron <[email protected]>
tjzhang-BQ
force-pushed
the
java/python/integ_tjz_entriesread
branch
from
a183ef5 to
32c6e5e
Compare
Yury-Fridlyand
approved these changes
Jul 3, 2024
acarbonetto
reviewed
Jul 3, 2024
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
Jul 3, 2024
acarbonetto
approved these changes
Jul 3, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 16, 2024
* Java: type migration for entries_read * Update java/client/src/main/java/glide/api/BaseClient.java Co-authored-by: Yury-Fridlyand <[email protected]> * small fix variable name * renaming argument for xgroupSetId * changing to using primitive long and applying checkstyle * Update java/client/src/main/java/glide/api/models/BaseTransaction.java Co-authored-by: Aaron <[email protected]> * change entriesread type for BaseTransaction --------- Co-authored-by: TJ Zhang <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.