Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: JSON.CLEAR. #2519

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Java: JSON.CLEAR. #2519

merged 5 commits into from
Oct 25, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Issue link

#2430

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@Yury-Fridlyand
JSON.CLEAR.
8562f3e 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Oct 25, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 25, 2024 00:56
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 25, 2024
Closed
22 tasks
@Yury-Fridlyand
typo fix
292c9d2 
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
acarbonetto approved these changes Oct 25, 2024
View reviewed changes
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/modules/JsonTests.java Show resolved Hide resolved
@Yury-Fridlyand
Address PR review.
fdbf58b 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
typo fix
e3d5d00 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit e2c3b8a into release-1.2 Oct 25, 2024
14 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/yuryf-jclear-valkey-445 branch October 25, 2024 22:37
BoazBD pushed a commit to BoazBD/valkey-glide that referenced this pull request Oct 27, 2024
@Yury-Fridlyand @BoazBD
Java: JSON.CLEAR. (valkey-io#2519)
3a8dd26 
* `JSON.CLEAR`.

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: BoazBD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @acarbonetto @yipin-chen