Node rc fixes + unpublish on failure mechanism #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
avifenesh
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
avifenesh
force-pushed
the
node-rc
branch
2 times, most recently
from
03709bd to
8a8be2e
Compare
avifenesh
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
avifenesh
force-pushed
the
node-rc
branch
2 times, most recently
from
0b53d46 to
cd9f112
Compare
…ublish feature Signed-off-by: avifenesh <[email protected]>
avifenesh
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
avifenesh
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
avifenesh
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
avifenesh
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
…ce the usage is deprecating Signed-off-by: avifenesh <[email protected]>
avifenesh
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
ikolomi
approved these changes
Nov 25, 2024
prateek-kumar-improving
pushed a commit
that referenced
this pull request
Nov 26, 2024
* Update Node.js Docker image and enhance npm publish workflow with unpublish feature Signed-off-by: avifenesh <[email protected]> * unpublishing a package owned by more than one cant be unpublised, hence the usage is deprecating Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]>
avifenesh
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
avifenesh
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the build and deployment workflows, as well as dependency updates. The most important changes are improvements to the npm publish process, the addition of a package deprecation step on failure, and updates to the build matrix and dependencies.
Workflow improvements:
.github/workflows/npm-cd.yml: Improved the npm publish process by enhancing error handling and logging, and simplified the command to filter out notices and warnings..github/workflows/npm-cd.yml: Added a step to deprecate packages if the job fails, ensuring deprecated packages are marked correctly. This includes installingjqand setting theRELEASE_VERSIONbased on environment variables.Build matrix updates:
.github/json_matrices/build-matrix.json: Updated the Docker image to usenode:lts-alpineinstead of a specific version (node:lts-alpine3.19). This change applies to both ARM64 and x64 architectures. [1] [2]Dependency updates:
node/package.json: Updatedtypescriptto version^5.6.3anduuidto version^11.0.3to ensure compatibility and leverage the latest features and fixes.Issue link
This Pull Request is linked to issue (#2735)
Checklist
Before submitting the PR make sure the following are checked: