Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node test for checking exported symbols #2835

Merged
merged 74 commits into from
Feb 7, 2025
Merged

Add node test for checking exported symbols #2835

merged 74 commits into from
Feb 7, 2025

Conversation

prateek-kumar-improving
Copy link
Collaborator

@prateek-kumar-improving prateek-kumar-improving commented Dec 18, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2335

Issue to track improvement and refactoring tasks found during review: #3028

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@prateek-kumar-improving prateek-kumar-improving marked this pull request as ready for review December 18, 2024 06:44
@prateek-kumar-improving prateek-kumar-improving requested a review from a team as a code owner December 18, 2024 06:44
@prateek-kumar-improving
Add package.json.tmpl file
9bfb65d 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Fix formatting
be79255 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
formatting fixed
1df6ec1 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Formatting fixed
cb320e2 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Fix formatting
540180f 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Formatting fixed
c2cbf13 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: Change log updated
77c6c1c 
Signed-off-by: Prateek Kumar <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red

node/DEVELOPER.md Outdated Show resolved Hide resolved
node/DEVELOPER.md Outdated Show resolved Hide resolved
node/DEVELOPER.md Show resolved Hide resolved
node/DEVELOPER.md Outdated Show resolved Hide resolved
node/DEVELOPER.md Outdated Show resolved Hide resolved
node/npm/glide/package.json.tmpl Outdated Show resolved Hide resolved
node/npm/glide/package.json.tmpl Outdated Show resolved Hide resolved
node/npm/glide/tests/ExportedSymbols.test.ts Outdated Show resolved Hide resolved
node/package.json.tmpl Outdated Show resolved Hide resolved
node/npm/glide/tests/ExportedSymbols.test.ts Show resolved Hide resolved
@prateek-kumar-improving
Node: Add npm install
2d100ee 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: update changelog.md
7d9ae5a 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: Add changelog.md
d7c4254 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: update package.json
6a4a30c 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: update action.yml
e6b0e72 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: update action.yml
ab2e8f9 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: update action.yml
bb5bfa6 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: remove temp file
03e6389 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: fix review comments
e2411ab 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: add constant variables
a02748e 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Node: fixed formatting
ed54b7b 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving prateek-kumar-improving merged commit 3a4d7dc into main Feb 7, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@jamesx-improving jamesx-improving jamesx-improving approved these changes

@acarbonetto acarbonetto Awaiting requested review from acarbonetto

@avifenesh avifenesh Awaiting requested review from avifenesh

Assignees
No one assigned
Labels
node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prateek-kumar-improving @avifenesh @Yury-Fridlyand @jamesx-improving