Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement GetBit, SetBit, BitCount and Wait commands #2918

Merged
merged 22 commits into from
Jan 21, 2025
Merged

Go: Implement GetBit, SetBit, BitCount and Wait commands #2918

merged 22 commits into from
Jan 21, 2025

Conversation

niharikabhavaraju
Copy link
Collaborator

Go: Implement GetBit, SetBit, BitCount and Wait commands

@niharikabhavaraju
Added bitmap commands,wait commands
b86f764 
Signed-off-by: Niharika Bhavaraju <[email protected]>
@niharikabhavaraju niharikabhavaraju requested a review from a team as a code owner January 6, 2025 10:18
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 6, 2025
View reviewed changes
go/api/options/bitcount_options.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 13, 2025
View reviewed changes
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/api/generic_base_commands.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Jan 16, 2025
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 16, 2025
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/api/bitmap_commands.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand approved these changes Jan 17, 2025
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to click "resolve" on simple changes which you're resolving.

go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
@janhavigupta007 janhavigupta007 merged commit 918162b into valkey-io:main Jan 21, 2025
18 checks passed
Maayanshani25 pushed a commit to Maayanshani25/valkey-glide that referenced this pull request Jan 22, 2025
@niharikabhavaraju @Maayanshani25
Go: Implement GetBit, SetBit, BitCount and Wait commands (valkey-io#2918
c6e3b32 
)

* Added bitmap commands,wait commands

Signed-off-by: Niharika Bhavaraju <[email protected]>
EdricCua pushed a commit to EdricCua/valkey-glide that referenced this pull request Jan 23, 2025
@niharikabhavaraju @EdricCua
Go: Implement GetBit, SetBit, BitCount and Wait commands (valkey-io#2918
8613dcf 
)

* Added bitmap commands,wait commands

Signed-off-by: Niharika Bhavaraju <[email protected]>
EdricCua pushed a commit to EdricCua/valkey-glide that referenced this pull request Jan 23, 2025
@niharikabhavaraju @EdricCua
Go: Implement GetBit, SetBit, BitCount and Wait commands (valkey-io#2918
03537bf 
)

* Added bitmap commands,wait commands

Signed-off-by: Niharika Bhavaraju <[email protected]>
eifrah-aws pushed a commit to eifrah-aws/glide-for-redis that referenced this pull request Jan 23, 2025
@niharikabhavaraju @eifrah-aws
Go: Implement GetBit, SetBit, BitCount and Wait commands (valkey-io#2918
6eebe16 
)

* Added bitmap commands,wait commands

Signed-off-by: Niharika Bhavaraju <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 25, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niharikabhavaraju @Yury-Fridlyand @janhavigupta007