Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster_manager script #2940

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

Valkey changed template for --version

$ ./valkey-7.2.8 --version
Server v=7.2.8 sha=f6852069:0 malloc=jemalloc-5.3.0 bits=64 build=67cf89c66d1115f6
$ ./redis-7.2.3 --version
Redis server v=7.2.3 sha=00000000:0 malloc=jemalloc-5.3.0 bits=64 build=9b0796a828280810
$ ./valkey-8 --version
Valkey server v=8.0.0 sha=2b5c7a0d:0 malloc=jemalloc-5.3.0 bits=64 build=3c5eadb1cbf9fac2

Need to adopt script, otherwise it crashes all CI on version 7.2

Traceback (most recent call last):
  File "/mnt/c/GitHub/babushka/utils/./cluster_manager.py", line 1257, in <module>
    main()
  File "/mnt/c/GitHub/babushka/utils/./cluster_manager.py", line 1193, in main
    servers = create_servers(
              ^^^^^^^^^^^^^^^
  File "/mnt/c/GitHub/babushka/utils/./cluster_manager.py", line 472, in create_servers
    start_server(
  File "/mnt/c/GitHub/babushka/utils/./cluster_manager.py", line 374, in start_server
    server_version = get_server_version(server_name)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/mnt/c/GitHub/babushka/utils/./cluster_manager.py", line 371, in get_server_version
    raise Exception("Unable to determine server version.")

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the CI/CD CI/CD related label Jan 11, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner January 11, 2025 21:10
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can rollback if we see any build errors.

@Yury-Fridlyand
Copy link
Collaborator Author

Tested manually and with https://regex101.com/r/D6L9nQ/1

@Yury-Fridlyand Yury-Fridlyand merged commit b0c79ab into valkey-io:main Jan 15, 2025
58 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the ci/fix-cluster-manager branch January 15, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants