Go: Implement Time Command #2963
Open
+231
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Yury-Fridlyand
approved these changes
Jan 17, 2025
Signed-off-by: Niharika Bhavaraju <[email protected]>
|
@Yury-Fridlyand I have added Time for cluster (2x) can you please review. |
Comment on lines
+77
to
+100
| if err := checkResponseType(res, C.Map, true); err == nil { | ||
|
|
||
| // Multi-node response | ||
| mapData, err := handleRawStringArrayMapResponse(res) | ||
| if err != nil { | ||
| return ClusterValue[[]string]{ | ||
| value: Result[[]string]{isNil: true}, | ||
| }, err | ||
| } | ||
| var times []string | ||
| for _, nodeTimes := range mapData { | ||
| times = append(times, nodeTimes...) | ||
| } | ||
| return CreateClusterMultiValue(times), nil | ||
| } | ||
|
|
||
| // Single node response | ||
| data, err := handleRawStringArrayResponse(res) | ||
| if err != nil { | ||
| return ClusterValue[[]string]{ | ||
| value: Result[[]string]{isNil: true}, | ||
| }, err | ||
| } | ||
| return CreateClusterSingleValue(data), nil |
There was a problem hiding this comment.
Shouldn't be that code be in response handlers?
Comment on lines
+72
to
+74
| return ClusterValue[[]string]{ | ||
| value: Result[[]string]{isNil: true}, | ||
| }, err |
There was a problem hiding this comment.
Please use CreateEmptyClusterValue()
| // | ||
| // [valkey.io]: https://valkey.io/commands/#server | ||
| type ServerManagementClusterCommands interface { | ||
| Time(route route) (ClusterValue[[]string], error) |
There was a problem hiding this comment.
This should be TimeWithRoute or TimeWithOptions, I prefer TimeWithOptions, see discussion in #2979 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go: Implement Time Command