Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add stream commands XGroupCreateConsumer/XGroupDelConsumer #2975

Merged
merged 14 commits into from
Jan 20, 2025
Merged

Go: Add stream commands XGroupCreateConsumer/XGroupDelConsumer #2975

merged 14 commits into from
Jan 20, 2025

Conversation

jbrinkman
Copy link
Collaborator

This adds the following stream commands for the Go client:

  • XGroupCreateConsumer
  • XGroupDelConsumer

Issue link

This Pull Request is linked to issue (#2968):

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@jbrinkman jbrinkman requested a review from a team as a code owner January 17, 2025 23:01
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Jan 17, 2025
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 17, 2025
Closed
5 tasks
@jbrinkman jbrinkman force-pushed the go/jbrinkman-xgroupcreateconsumer branch from fe21025 to 2119e59 Compare January 18, 2025 01:48
Yury-Fridlyand
Yury-Fridlyand approved these changes Jan 18, 2025
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 20, 2025
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
@jbrinkman jbrinkman force-pushed the go/jbrinkman-xgroupcreateconsumer branch from 0b57828 to 37c1a6d Compare January 20, 2025 18:29
jbrinkman and others added 14 commits January 20, 2025 13:35
@jbrinkman
go xGroupCreateConsumer and XGroupDelConsumer
fa14fd1 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
add integration tests
8bafc22 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
add integration tests
71fdaf9 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
add command comments
9feedaa 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
fix linting error with unused variables
54c96b2 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
fix unused import
3e1b419 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
fix format
44a7676 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update go/api/base_client.go
46b5926 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
chore: cleanup doc comment
9fd744e 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update go/integTest/shared_commands_test.go
0b5385f 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
fix compilation error
7fd126d 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update go/api/base_client.go
ffb5fc2 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman @Yury-Fridlyand
Update go/api/base_client.go
09be0f9 
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joseph Brinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman
code review feedback updates
74ae821 
Signed-off-by: jbrinkman <[email protected]>
@jbrinkman jbrinkman force-pushed the go/jbrinkman-xgroupcreateconsumer branch from 37c1a6d to 74ae821 Compare January 20, 2025 18:41
@jbrinkman jbrinkman merged commit 084a68b into main Jan 20, 2025
17 of 18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the go/jbrinkman-xgroupcreateconsumer branch January 20, 2025 19:00
edlng pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jan 20, 2025
@jbrinkman @Yury-Fridlyand @edlng
Go: Add stream commands XGroupCreateConsumer/XGroupDelConsumer (valke…
c37ca67 
…y-io#2975)

* go xGroupCreateConsumer and XGroupDelConsumer

Signed-off-by: jbrinkman <[email protected]>

Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrinkman @Yury-Fridlyand @prateek-kumar-improving