Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement Echo Connection Management Cluster #2993

Merged
merged 26 commits into from
Jan 31, 2025
Merged

Go: Implement Echo Connection Management Cluster #2993

merged 26 commits into from
Jan 31, 2025

Conversation

EdricCua
Copy link
Collaborator

Issue link

This Pull Request is linked to issue (URL): #2874

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@EdricCua EdricCua requested a review from a team as a code owner January 23, 2025 00:33
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Jan 23, 2025
@EdricCua EdricCua force-pushed the Go-Echo-ConnectionMangementCluster branch from f674539 to efc1a1d Compare January 23, 2025 14:02
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 25, 2025
View reviewed changes
go/integTest/standalone_commands_test.go Outdated Show resolved Hide resolved
go/api/glide_cluster_client.go Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 25, 2025
Closed
4 tasks
@EdricCua EdricCua force-pushed the Go-Echo-ConnectionMangementCluster branch from abfc6ca to 79a02da Compare January 28, 2025 07:49
@EdricCua
Implement Echo Cluster
4866a17 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Echo Cluster
1693966 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Echo Cluster
8a34022 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Get update from main
4abe159 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Echo Cluster
8f8c702 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Echo Cluster
f053d39 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 28, 2025
View reviewed changes
go/api/command_options.go Outdated Show resolved Hide resolved
go/api/command_options.go Outdated Show resolved Hide resolved
@EdricCua
Fix Echo cluster command
37e16f4 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
98fa73c 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
2385487 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
5fbc2bb 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
3eea241 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix test
c0f5646 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix test
01c7ec7 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor things

go/api/glide_cluster_client.go Outdated Show resolved Hide resolved
go/api/options/echo_options.go Outdated Show resolved Hide resolved
go/api/options/route_options.go Outdated Show resolved Hide resolved
@EdricCua
Fix merge conflict
2345a4e 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Addressed review comments
a6f1f75 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Addressed review comments
c02b0e5 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
2fe42f6 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
4cd2d84 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
d19c94e 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
181a1b2 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
b09e377 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
046036a 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
1844b96 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
86cc185 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
4675569 
Signed-off-by: EdricCua <[email protected]>
@jbrinkman jbrinkman merged commit ae5f461 into valkey-io:main Jan 31, 2025
18 checks passed
adarovadya pushed a commit to adarovadya/glide-for-redis that referenced this pull request Feb 3, 2025
@EdricCua
Go: Implement Echo Connection Management Cluster (valkey-io#2993)
16ab16a 
* Implement Echo Connection Management Cluster

Signed-off-by: EdricCua <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzhang-BQ tjzhang-BQ tjzhang-BQ left review comments

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EdricCua @Yury-Fridlyand @tjzhang-BQ @prateek-kumar-improving @jbrinkman