-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: updating error message in thread pool supplier #3001
Conversation
Signed-off-by: TJ Zhang <[email protected]>
This PR needs to add a link to a relevant Issue. If one does not exist then it should be created from the information contained in our internal board. Additionally, please verify the items in the checklist and update it appropriately |
@@ -64,6 +64,13 @@ public static Supplier<ThreadPoolResource> getThreadPoolResourceSupplier() { | |||
return EpollResource::new; | |||
} | |||
// TODO support IO-Uring and NIO | |||
throw new RuntimeException("Current platform supports no known thread pool resources"); | |||
String errorMessage = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this adequately describes the problem, and identifies some system information, is there an solution, fixes, or workarounds that the user might try to resolve the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Joe. I think we may need to suggest NIO in the future as a workaround once that's implemented, but for now we can leave that out. We might want to add some OS detection logic to suggest either epoll or kqueue though.
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Issue link
This Pull Request is linked to issue (URL): #3006
Checklist
Before submitting the PR make sure the following are checked: