Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: updating error message in thread pool supplier #3001

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Jan 24, 2025

Issue link

This Pull Request is linked to issue (URL): #3006

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@tjzhang-BQ tjzhang-BQ added the java issues and fixes related to the java client label Jan 24, 2025
@jbrinkman
Copy link
Collaborator

This PR needs to add a link to a relevant Issue. If one does not exist then it should be created from the information contained in our internal board.

Additionally, please verify the items in the checklist and update it appropriately

@@ -64,6 +64,13 @@ public static Supplier<ThreadPoolResource> getThreadPoolResourceSupplier() {
return EpollResource::new;
}
// TODO support IO-Uring and NIO
throw new RuntimeException("Current platform supports no known thread pool resources");
String errorMessage =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this adequately describes the problem, and identifies some system information, is there an solution, fixes, or workarounds that the user might try to resolve the issue?

Copy link
Collaborator

@jonathanl-bq jonathanl-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Joe. I think we may need to suggest NIO in the future as a workaround once that's implemented, but for now we can leave that out. We might want to add some OS detection logic to suggest either epoll or kqueue though.

Signed-off-by: Yury-Fridlyand <[email protected]>
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review January 27, 2025 18:06
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner January 27, 2025 18:06
Signed-off-by: Yury-Fridlyand <[email protected]>
@tjzhang-BQ tjzhang-BQ merged commit 5bc30ae into main Jan 31, 2025
16 checks passed
@tjzhang-BQ tjzhang-BQ deleted the java/tjz-errmsg branch January 31, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants