Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add command zinter #3021

Merged
merged 7 commits into from
Feb 1, 2025
Merged

Go: Add command zinter #3021

merged 7 commits into from
Feb 1, 2025
+277 −7

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Jan 28, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2972

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@tjzhang-BQ tjzhang-BQ added the go golang wrapper label Jan 28, 2025
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner January 28, 2025 02:14
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 28, 2025
View reviewed changes
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/options/zinter_options.go Show resolved Hide resolved
go/api/options/weight_aggregate_options.go Show resolved Hide resolved
yipin-chen
yipin-chen approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing minor comment error.

TJ Zhang and others added 5 commits January 31, 2025 16:01
linter
210e4dd 
Signed-off-by: TJ Zhang <[email protected]>
@tjzhang-BQ tjzhang-BQ merged commit 330160d into main Feb 1, 2025
17 of 18 checks passed
@tjzhang-BQ tjzhang-BQ deleted the go/tjz-zinter branch February 1, 2025 01:44
@yipin-chen yipin-chen mentioned this pull request Feb 1, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjzhang-BQ @Yury-Fridlyand @yipin-chen @prateek-kumar-improving