Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Open telemetry client config #3023

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Core: Open telemetry client config #3023

merged 4 commits into from
Feb 4, 2025

Conversation

adarovadya
Copy link
Collaborator

@adarovadya adarovadya commented Jan 28, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): issues-2901

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@adarovadya adarovadya requested a review from a team as a code owner January 28, 2025 21:55
@adarovadya adarovadya force-pushed the open-telemetry-clients-config branch from ac7b81e to f2264e2 Compare January 28, 2025 22:03
@adarovadya adarovadya requested a review from eifrah-aws January 28, 2025 22:04
eifrah-aws
eifrah-aws requested changes Feb 2, 2025
View reviewed changes
glide-core/redis-rs/redis/src/cluster_client.rs Show resolved Hide resolved
glide-core/src/client/mod.rs Outdated Show resolved Hide resolved
glide-core/src/client/types.rs Outdated Show resolved Hide resolved
glide-core/src/client/types.rs Outdated Show resolved Hide resolved
glide-core/telemetry/src/open_telemetry.rs Outdated Show resolved Hide resolved
@adarovadya adarovadya force-pushed the open-telemetry-clients-config branch 2 times, most recently from 66cff1d to 0c71a19 Compare February 3, 2025 18:47
Adar Ovadia added 4 commits February 4, 2025 08:07
add OpenTelemetry client configs
9f97f06 
Signed-off-by: Adar Ovadia <[email protected]>
core: add open telemetry config
9dfe4fc 
Signed-off-by: Adar Ovadia <[email protected]>
make the protobuf span optionaly
65b98a4 
Signed-off-by: Adar Ovadia <[email protected]>
fix pr comments
7cf3aa6 
Signed-off-by: Adar Ovadia <[email protected]>
@adarovadya adarovadya force-pushed the open-telemetry-clients-config branch from afdfd6a to 7cf3aa6 Compare February 4, 2025 08:08
@adarovadya adarovadya merged commit cd94f51 into valkey-io:main Feb 4, 2025
58 checks passed
@adarovadya adarovadya deleted the open-telemetry-clients-config branch February 4, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eifrah-aws eifrah-aws eifrah-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adarovadya @eifrah-aws