Go: ZDiff command added #3032
Open
Go: ZDiff command added #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
8 tasks
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
edlng
reviewed
Jan 31, 2025
| @@ -7011,3 +7011,75 @@ func (client *baseClient) Time() ([]string, error) { | |||
| } | |||
| return handleStringArrayResponse(result) | |||
| } | |||
|
|
|||
| // Returns the difference between the first sorted set and all the successive sorted sets.<br> | |||
There was a problem hiding this comment.
Suggested change
| // Returns the difference between the first sorted set and all the successive sorted sets.<br> | |
| // Returns the difference between the first sorted set and all the successive sorted sets. |
yipin-chen
approved these changes
Jan 31, 2025
tjzhang-BQ
reviewed
Jan 31, 2025
|
|
||
| // Returns the difference between the first sorted set and all the successive sorted sets.<br> | ||
| // To get the elements with their scores, see `ZDiffWithScores` | ||
| // When in cluster mode, all `keys` must map to the same hash slot. |
There was a problem hiding this comment.
maybe put an empty line between the main command description and the cluster note?
tjzhang-BQ
reviewed
Jan 31, 2025
| @@ -9,6 +9,7 @@ const ( | |||
| WithScore string = "WITHSCORE" // Valkey API keyword for the with score option for zrank and zrevrank commands. | |||
There was a problem hiding this comment.
does any command specifically ask for withscore without the s?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2972
Checklist
Before submitting the PR make sure the following are checked: