[to remove] Java benchmarks: add `Jedis` and `Lettuce` clients (sync and async) #540

Yury-Fridlyand · 2023-10-25T00:25:14Z

Description of changes:

Base classes to execute performance test on different redis clients.
Wrappers for Jedis and Lettuce clients.

Notes:

Jedis has no async API, so Jedis async API replaced by Java async features
Jedis does not support concurrent access

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: acarbonetto <[email protected]>

This reverts commit d9b26a6.

Signed-off-by: acarbonetto <[email protected]>

* Add a java app to run benchmarks --------- Signed-off-by: acarbonetto <[email protected]>

Signed-off-by: acarbonetto <[email protected]>

* Merge Pull Request #5 - Add java pipeline. Also changed: * Merged two projects. * Updated CI. * Fixed tests and updated `junit` version. * Spotless. * Add new gradle tasks. Signed-off-by: Yury-Fridlyand <[email protected]>

* Add sync and async clients both to tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>

…onvert to TypeScript. (valkey-io#456) removed duplicated logic and refactored to typescript Signed-off-by: acarbonetto <[email protected]>

* Add Jedis and Lettuce benchmarks * Start ignoring .gradle files * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Add benchmarks for GET non-existing * Revert "Update gitignore and remove generated files from git" This reverts commit d9b26a6. * fix redis-rs submodules Signed-off-by: acarbonetto <[email protected]> * Randomize commands in Java benchmarks * rename chooseAction to randomAction * Add a Java benchmarking app (#7) * Add a java app to run benchmarks --------- Signed-off-by: acarbonetto <[email protected]> * Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> * Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> * Combine java pipeline and java benchmarks (#8) * Merge Pull Request #5 - Add java pipeline. Also changed: * Merged two projects. * Updated CI. * Fixed tests and updated `junit` version. * Spotless. * Add new gradle tasks. Signed-off-by: Yury-Fridlyand <[email protected]> * Add sync and async clients both to tests. (#12) * Add sync and async clients both to tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> * Add dataSize option to java benchmark. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Jonathan Louie <[email protected]> Co-authored-by: acarbonetto <[email protected]> Co-authored-by: jonathanl-bq <[email protected]>

Signed-off-by: acarbonetto <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

* Add option to run tests on multiple clients in concurrency * Common pool of iterations. * Awaiting result from async methods. Signed-off-by: Yury-Fridlyand <[email protected]> * minor fix Signed-off-by: Yury-Fridlyand <[email protected]> * Change while-loop; Spotless Apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: acarbonetto <[email protected]> Co-authored-by: acarbonetto <[email protected]>

Signed-off-by: acarbonetto <[email protected]>

* Updated ClientCount to client_count for uniformity for rust.

* Add JSON reporting. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix for #26. Signed-off-by: Yury-Fridlyand <[email protected]> * Update java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Use `Optional`. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

…java_benchmarks Signed-off-by: Yury-Fridlyand <[email protected]>

barshaul · 2023-10-29T13:49:09Z

benchmarks/install_and_test.sh

+function runJavaBenchmark(){
+  cd ${BENCH_FOLDER}/../java
+  echo "./gradlew run --args=\"--resultsFile=${BENCH_FOLDER}/$1 --clients $chosenClients --host $host --port $port\""
+#  ./gradlew run --args="--resultsFile=../$1 --dataSize $2 --concurrentTasks $concurrentTasks --clients $chosenClients --host $host --port $port --clientCount $clientCount $tlsFlag"


Why is it commented out?

benchmarks/install_and_test.sh

java/benchmarks/src/main/java/javababushka/benchmarks/BenchmarkingApp.java

java/benchmarks/src/main/java/javababushka/benchmarks/AsyncClient.java

java/benchmarks/src/main/java/javababushka/benchmarks/BenchmarkingApp.java

barshaul · 2023-10-29T14:13:44Z

java/benchmarks/src/test/java/javababushka/benchmarks/lettuce/LettuceAsyncClientIT.java

+    try {
+      lettuceClient.waitForResult(setResult);
+    } catch (Exception e) {
+      fail("Can SET redis result without Exception");


I don't understand the exception message, should it be "can't"?

barshaul · 2023-10-29T14:28:44Z

java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java

+    try {
+      actions.get(action).go();
+    } catch (Exception e) {
+      // timed out - exception from Future::get


We don't want to measure performance with exceptions, we want to fail the benchmark on errors. Do you have timeout issues with one/some of the clients?

barshaul · 2023-10-29T14:56:52Z

java/benchmarks/src/main/java/javababushka/benchmarks/jedis/JedisClient.java

+  }
+
+  @Override
+  public void connectToRedis(ConnectionSettings connectionSettings) {


So we currently have benchmarks only for a standalone redis. Are you working on expanding it to cluster clients as well?

barshaul · 2023-10-29T15:07:43Z

java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java

+            tasks.add(
+                () -> {
+                  int iterationIncrement = iterationCounter.getAndIncrement();
+                  int clientIndex = iterationIncrement % clients.size();


It's different than what we have in the python and node benchmarks - here you attach a client to be used in the entire task, and in python/node the client is being chosen in each command.
In a case where concurrent tasks < number of clients, there will be clients that won't get any commands to run.

barshaul · 2023-10-29T15:12:55Z

java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java

+  public static Map<ChosenAction, Operation> getActionMap(
+      Client client, int dataSize, boolean async) {
+
+    String value = RandomStringUtils.randomAlphanumeric(dataSize);


To match python/node benchmarks please change the value to
"0".repeat(dataSize);

shachlanAmazon · 2023-11-02T07:39:43Z

hi, this is a pretty huge PR. If it can't be split into separate PRs, can you at least try to split it into coherent commits, so that each commit could be reviewed relatively separately? ATM you have a lot of tiny commits, with some reverts, and it's hard to understand in what order the changes should be reviewed.

Signed-off-by: acarbonetto <[email protected]>

barshaul · 2023-11-09T08:04:51Z

Hey @Yury-Fridlyand, once you're done - please tag us in a comment so we'll know it's ready for another round.

* Add lettuce cluster client when cluster mode enabled --------- Signed-off-by: Andrew Carbonetto <[email protected]>

Signed-off-by: acarbonetto <[email protected]>

shachlanAmazon

comments on the non-Java code.

shachlanAmazon · 2023-11-16T13:36:55Z

.vscode/launch.json

@@ -1,42 +0,0 @@
-{


please revert all of these deletions.

shachlanAmazon · 2023-11-16T13:37:01Z

.vscode/settings.json

@@ -1,37 +0,0 @@
-{


shachlanAmazon · 2023-11-16T13:37:07Z

.vscode/tasks.json

@@ -1,41 +0,0 @@
-{


shachlanAmazon · 2023-11-16T13:38:12Z

benchmarks/csharp/Program.cs

@@ -226,7 +226,7 @@ int num_of_concurrent_tasks
            {"num_of_tasks", num_of_concurrent_tasks},
            {"data_size", data_size},
            {"tps", tps},
-            {"clientCount", clients.Length},
+            {"client_count", clients.Length},


please try to keep PRs concise, and fix a single issue per-PR (or at least touch a single area of code). This and changes to non-java benchmarks, isn't relevant to this PR.

shachlanAmazon · 2023-11-16T13:44:30Z

benchmarks/node/node_benchmark.ts

@@ -167,7 +167,7 @@ async function run_clients(
        num_of_tasks: num_of_concurrent_tasks,
        data_size,
        tps,
-        clientCount: clients.length,


shachlanAmazon · 2023-11-16T13:44:34Z

benchmarks/python/python_benchmark.py

@@ -226,7 +226,7 @@ async def run_clients(
            "num_of_tasks": num_of_concurrent_tasks,
            "data_size": data_size,
            "tps": tps,
-            "clientCount": len(clients),


shachlanAmazon · 2023-11-16T13:44:38Z

benchmarks/rust/src/main.rs

@@ -130,7 +130,7 @@ async fn perform_benchmark(args: Args) {
            Value::Number((number_of_operations as i64 * 1000 / stopwatch.elapsed_ms()).into()),
        );
        results_json.insert(
-            "clientCount".to_string(),


shachlanAmazon

initial java comments.

shachlanAmazon · 2023-11-16T14:18:00Z

java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java

+                              iterationIncrement + 1, iterations, clientIndex + 1, clientCount);
+                        }
+
+                        var actions = getActionMap(clients.get(clientIndex), dataSize, async);


why does a new action map need to be created for each iteration? or more than once?

shachlanAmazon · 2023-11-16T14:24:06Z

java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java

+          asyncTasks.forEach(
+              future -> {
+                try {
+                  var futureResult = future.get();


I don't see where the different tasks are offloaded to different threads here. You don't use a fork/join service or an executor - this seems like the tasks are executed serially, instead of concurrently. what am I missing?

shachlanAmazon · 2023-11-16T14:34:29Z

java/benchmarks/src/main/java/javababushka/benchmarks/jedis/JedisClient.java

+  }
+
+  @Override
+  public void set(String key, String value) {


this seems like the wrong way to work with Jedis. first of all, all of the threads that share the same client also share the same jedisResource, which isn't threadsafe.
second, because Jedis doesn't support asynchronous API, the way to send multiple commands on the same connection concurrently is by using pipelines.

at the very least, you shouldn't reuse resources across threads, but a more accurate benchmark also wouldn't check single commands on each resource, but will pipeline multiple commands.

* Add Java-client benchmarking app Signed-off-by: acarbonetto <[email protected]> * spotless apply Signed-off-by: acarbonetto <[email protected]> * Update on command line options Signed-off-by: acarbonetto <[email protected]> * Update README Signed-off-by: acarbonetto <[email protected]> * Spotless apply: Signed-off-by: acarbonetto <[email protected]> * Update README example Signed-off-by: acarbonetto <[email protected]> * update commandline defaults for review comments Signed-off-by: acarbonetto <[email protected]> * Remove TLS flag argument from option Signed-off-by: acarbonetto <[email protected]> * Add lettuce clients for benchmarking Signed-off-by: acarbonetto <[email protected]> * Spotless apply Signed-off-by: acarbonetto <[email protected]> * Add Jedis clients Signed-off-by: acarbonetto <[email protected]> * Add to app Signed-off-by: acarbonetto <[email protected]> * Add for-loop for data size list Signed-off-by: acarbonetto <[email protected]> * Add TPS for all async items Signed-off-by: acarbonetto <[email protected]> * spotless apply Signed-off-by: acarbonetto <[email protected]> * Fix TPS calculations Signed-off-by: acarbonetto <[email protected]> * Accept TLS as a flag Signed-off-by: acarbonetto <[email protected]> * Start threads; then wait for results Signed-off-by: acarbonetto <[email protected]> * Add java-jni client Signed-off-by: acarbonetto <[email protected]> * Handle Exceptions from client; add JniSyncClient fixes Signed-off-by: acarbonetto <[email protected]> * Clean up latency and add error checking Signed-off-by: acarbonetto <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix result printing. Signed-off-by: Yury-Fridlyand <[email protected]> * Add TPS. Signed-off-by: Yury-Fridlyand <[email protected]> * Remove duplicates. Reorganize and fix imports. Signed-off-by: Yury-Fridlyand <[email protected]> * Int ctor fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 1. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 2: connected! Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 3: `get` and `set`. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 4: benchmark. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 5: some fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Change number of threads in Benchmarking threadpool * Revert "Change number of threads in Benchmarking threadpool" This reverts commit e3f7596. * Add more flushing rules and UT. Signed-off-by: Yury-Fridlyand <[email protected]> * Client clean up. Signed-off-by: Yury-Fridlyand <[email protected]> * Client optimizations. (#37) * Client optimizations. Signed-off-by: Yury-Fridlyand <[email protected]> * minor cleanup. Signed-off-by: Yury-Fridlyand <[email protected]> * Optimize building a command. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor rename. Signed-off-by: Yury-Fridlyand <[email protected]> * Clean up Redis close connection Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up Redis close connection Signed-off-by: Andrew Carbonetto <[email protected]> * Minor changes. Signed-off-by: Yury-Fridlyand <[email protected]> * Add todos to closeConnection() Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> * Rename Signed-off-by: Yury-Fridlyand <[email protected]> * Rename2 Signed-off-by: Yury-Fridlyand <[email protected]> * Fix CI Signed-off-by: Yury-Fridlyand <[email protected]> * More fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Some changes. Signed-off-by: Yury-Fridlyand <[email protected]> * add null check Signed-off-by: Yury-Fridlyand <[email protected]> * autoflush Signed-off-by: Yury-Fridlyand <[email protected]> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * minor changes Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: acarbonetto <[email protected]> Co-authored-by: Jonathan Louie <[email protected]>

shachlanAmazon · 2023-11-30T17:44:17Z

@acarbonetto why did you add "[to remove]" to the PR's name? this PR will be merged, not accumulated in other PRs, because it will make the next PR hard to review, because all of the code of this PR will be there, too. Github doesn't have a good mechanism for marking code as reviewed and to mark it out of the current PR. We merge PRs to main, not maintain long living branches.
By the same token, @Yury-Fridlyand, b50d57e doesn't look like it belongs in this PR.

Yury-Fridlyand · 2023-11-30T20:18:23Z

This PR is superseded by #629, #630, #631 and #632. We keep it open to ensure that we don't lost unresolved comments there.
We are going to close it unmerged.

shachlanAmazon · 2023-11-30T20:34:33Z

That is an intention, not an explanation for why would you do that. As I said, if this PR is superseded into other PRs, we will need to re-review it on every other PR. Additionally, what you're effectively suggesting is long-lived branches, which are a harder to maintain and update.
It will be hard to disambiguate reviewed changes from new changes in the PR. Why not merge it, and rebase later PRs?
Please answer with a rationale for this intention. Please, explain why doing it this way is better.

Yury-Fridlyand · 2023-11-30T20:45:50Z

You requested to split this PR, so what we actually did.

shachlanAmazon · 2023-12-01T12:07:24Z

oh, no. I owe you an apology - I followed the order of PRs in the wrong order. Yes, this PR should be removed.
My bad, sorry about this.

jonathanl-bq and others added 27 commits October 3, 2023 13:33

Add Jedis and Lettuce benchmarks

06574ea

Start ignoring .gradle files

5990767

Update gitignore and remove generated files from git

6ae93f5

Signed-off-by: acarbonetto <[email protected]>

Update gitignore and remove generated files from git

8203c4d

Signed-off-by: acarbonetto <[email protected]>

Update gitignore and remove generated files from git

e517744

Signed-off-by: acarbonetto <[email protected]>

Add benchmarks for GET non-existing

2a11e9a

Revert "Update gitignore and remove generated files from git"

cbb0dcb

This reverts commit d9b26a6.

fix redis-rs submodules

5f51a5b

Signed-off-by: acarbonetto <[email protected]>

Randomize commands in Java benchmarks

52df672

rename chooseAction to randomAction

84f0efc

Add a Java benchmarking app (#7)

1983974

* Add a java app to run benchmarks --------- Signed-off-by: acarbonetto <[email protected]>

Add Readme and update install_and_test script to runJava

6c1fb45

Signed-off-by: acarbonetto <[email protected]>

Add Readme and update install_and_test script to runJava

46d0cf6

Signed-off-by: acarbonetto <[email protected]>

Combine java pipeline and java benchmarks (#8)

d526f96

* Merge Pull Request #5 - Add java pipeline. Also changed: * Merged two projects. * Updated CI. * Fixed tests and updated `junit` version. * Spotless. * Add new gradle tasks. Signed-off-by: Yury-Fridlyand <[email protected]>

Add sync and async clients both to tests. (#12)

436da8f

* Add sync and async clients both to tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>

Move duplicated logic in benchmark JS scripts to a single file, and c…

016f5f6

…onvert to TypeScript. (valkey-io#456) removed duplicated logic and refactored to typescript Signed-off-by: acarbonetto <[email protected]>

Rename jabushka to javababushka (#14)

8664d05

Signed-off-by: acarbonetto <[email protected]>

Add missing renames. (#17)

b15f93e

Signed-off-by: Yury-Fridlyand <[email protected]>

Update redis-rs to match main branch

d99d27a

Signed-off-by: acarbonetto <[email protected]>

Create clients only once per iteration (#19)

540f49a

Signed-off-by: acarbonetto <[email protected]>

Updated ClientCount to client_count for uniformity.

65090b4

Convert client count to snake case for rust benchmark. (#27)

8a0449d

* Updated ClientCount to client_count for uniformity for rust.

Merge remote-tracking branch 'upstream/main' into java_benchmarks

fe9bb98

Signed-off-by: Yury-Fridlyand <[email protected]>

Typo fix.

d533b7f

Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand requested review from jonathanl-bq, barshaul and asafpamzn October 25, 2023 00:25

Yury-Fridlyand requested review from shachlanAmazon, acarbonetto and Elen-Ghulam October 25, 2023 00:25

Yury-Fridlyand requested a review from a team as a code owner October 25, 2023 00:25

Yury-Fridlyand added 2 commits October 25, 2023 11:15

Typo fix.

9cbc9c2

Signed-off-by: Yury-Fridlyand <[email protected]>

Merge branch 'java_benchmarks' of github.com:Bit-Quill/babushka into …

b00a205

…java_benchmarks Signed-off-by: Yury-Fridlyand <[email protected]>

barshaul requested changes Oct 29, 2023

View reviewed changes

acarbonetto added 2 commits November 6, 2023 14:50

fix java install_and_test script variables

a62fe92

Signed-off-by: acarbonetto <[email protected]>

Merge branch 'main' into java_benchmarks

30f2f62

acarbonetto added 2 commits November 14, 2023 11:41

Java benchmarks clusters (#34)

05590b0

* Add lettuce cluster client when cluster mode enabled --------- Signed-off-by: Andrew Carbonetto <[email protected]>

Clean up timer

bcf188c

Signed-off-by: acarbonetto <[email protected]>

shachlanAmazon reviewed Nov 16, 2023

View reviewed changes

shachlanAmazon mentioned this pull request Nov 23, 2023

Add benchmarking application. No test clients yet. #629

Merged

acarbonetto changed the title ~~Java benchmarks: add Jedis and Lettuce clients (sync and async)~~ [to remove] Java benchmarks: add Jedis and Lettuce clients (sync and async) Nov 24, 2023

Yury-Fridlyand closed this Dec 15, 2023

Yury-Fridlyand deleted the java_benchmarks branch December 15, 2023 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[to remove] Java benchmarks: add `Jedis` and `Lettuce` clients (sync and async) #540

[to remove] Java benchmarks: add `Jedis` and `Lettuce` clients (sync and async) #540

Yury-Fridlyand commented Oct 25, 2023 •

edited

Loading

barshaul Oct 29, 2023

barshaul Oct 29, 2023

barshaul Oct 29, 2023

barshaul Oct 29, 2023

barshaul Oct 29, 2023

barshaul Oct 29, 2023

shachlanAmazon commented Nov 2, 2023

barshaul commented Nov 9, 2023

shachlanAmazon left a comment

shachlanAmazon Nov 16, 2023

shachlanAmazon Nov 16, 2023

shachlanAmazon Nov 16, 2023

shachlanAmazon Nov 16, 2023

shachlanAmazon Nov 16, 2023

shachlanAmazon Nov 16, 2023

shachlanAmazon Nov 16, 2023

shachlanAmazon left a comment

shachlanAmazon Nov 16, 2023

shachlanAmazon Nov 16, 2023

shachlanAmazon Nov 16, 2023

shachlanAmazon commented Nov 30, 2023

Yury-Fridlyand commented Nov 30, 2023

shachlanAmazon commented Nov 30, 2023

Yury-Fridlyand commented Nov 30, 2023

shachlanAmazon commented Dec 1, 2023

[to remove] Java benchmarks: add Jedis and Lettuce clients (sync and async) #540

[to remove] Java benchmarks: add Jedis and Lettuce clients (sync and async) #540

Conversation

Yury-Fridlyand commented Oct 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shachlanAmazon commented Nov 2, 2023

barshaul commented Nov 9, 2023

shachlanAmazon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shachlanAmazon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shachlanAmazon commented Nov 30, 2023

Yury-Fridlyand commented Nov 30, 2023

shachlanAmazon commented Nov 30, 2023

Yury-Fridlyand commented Nov 30, 2023

shachlanAmazon commented Dec 1, 2023

[to remove] Java benchmarks: add `Jedis` and `Lettuce` clients (sync and async) #540

[to remove] Java benchmarks: add `Jedis` and `Lettuce` clients (sync and async) #540

Yury-Fridlyand commented Oct 25, 2023 •

edited

Loading