Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf/protoc version installed in CI. #672

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Issue #, if available:

N/A

Description of changes:

  1. Update protobuf/protoc version installed in CI.
  2. Minor reorganize CI to reuse install-shared-dependencies action.

Reason:
apt-get installs protoc v. 3.12, brew (on mac) installs 3.24 (24.3), whereas 3.25 (25.1) is already available. Having different versions on different platform may lead to issues.
For example, in java, 3.25 generates following functions:

response.hasRequestError()
response.hasClosingError()
response.hasConstantResponse()

and so on.
protoc v.3.12 doesn't generate these functions, but they are essential to validate the response content.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Yury-Fridlyand <[email protected]>
@shachlanAmazon shachlanAmazon merged commit f4c69b2 into valkey-io:main Dec 13, 2023
18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the ci/integ_yuryf_update_protobuf branch December 15, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants