-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
### Renaming project to GLIDE for Redis ### #699
Conversation
aaf0222
to
9d446fd
Compare
77478c8
to
cd8639d
Compare
@@ -1,9 +1,9 @@ | |||
package babushka.benchmarks; | |||
package glide.benchmarks; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rename the directory to reflect package name change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed, can you please verify that the whole Java functionalities are working with the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added number of new files in #670 to java/client
Please, rename the directory and package name there and other references to babushka
@@ -7,8 +8,7 @@ import { | |||
createLeakedDouble, | |||
createLeakedMap, | |||
createLeakedString, | |||
} from "babushka-rs-internal"; | |||
import fs from "fs"; | |||
} from "glide-rs-internal"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's be consistent - just like in python use "glide" for the rust part of the Typescript wrapper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decided on glide-rs for all internal rust bindings
``` | ||
3. After installation, confirm the client is installed by running: | ||
```bash | ||
$ npm list | ||
myApp@ /home/ubuntu/myApp | ||
└── babushka@0.1.0 | ||
└── glide-for-redis@0.1.0 | ||
``` | ||
|
||
### Build from source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this PR: build from source should be in DEVELOPER.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have #703 to do that
csharp/lib/Message.cs
Outdated
@@ -1,7 +1,7 @@ | |||
using System.Diagnostics; | |||
using System.Runtime.CompilerServices; | |||
using System.Runtime.InteropServices; | |||
using babushka; | |||
using glide; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, but namespaces should be Capitalized in C#, so - Glide.
59b17c3
to
4a85010
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be replaced/renamed by GlideCoreNativeDefinitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And updated with class rename and lib name
So final class should be
package glide.ffi.resolvers;
public class GlideCoreNativeDefinitions {
public static native String startSocketListenerExternal() throws Exception;
public static native Object valueFromPointer(long pointer);
static {
System.loadLibrary("glide-rs");
}
/**
* Make an FFI call to obtain the socket path.
*
* @return A UDS path.
*/
public static String getSocket() {
try {
return startSocketListenerExternal();
} catch (Exception | UnsatisfiedLinkError e) {
System.err.printf("Failed to create a UDS connection: %s%n%n", e);
throw new RuntimeException(e);
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, was mistakenly saved to another folder.
java/client/src/main/java/glide/connectors/handlers/GlideCoreNativeDefinitions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update package
in every java source file (first line)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep not sure why it wasn't commited, fixing. thx
47caa1c
to
2178441
Compare
2178441
to
7191a3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java ok
Rebased over #712