Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

### Renaming project to GLIDE for Redis ### #699

Merged
merged 14 commits into from
Dec 21, 2023

Conversation

barshaul
Copy link
Collaborator

@barshaul barshaul commented Dec 19, 2023

Rebased over #712

@barshaul barshaul force-pushed the pre_release branch 2 times, most recently from aaf0222 to 9d446fd Compare December 19, 2023 14:29
@barshaul barshaul marked this pull request as ready for review December 19, 2023 16:12
@@ -1,9 +1,9 @@
package babushka.benchmarks;
package glide.benchmarks;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rename the directory to reflect package name change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed, can you please verify that the whole Java functionalities are working with the PR?

java/benchmarks/build.gradle Outdated Show resolved Hide resolved
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added number of new files in #670 to java/client
Please, rename the directory and package name there and other references to babushka

node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
@@ -7,8 +8,7 @@ import {
createLeakedDouble,
createLeakedMap,
createLeakedString,
} from "babushka-rs-internal";
import fs from "fs";
} from "glide-rs-internal";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's be consistent - just like in python use "glide" for the rust part of the Typescript wrapper.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decided on glide-rs for all internal rust bindings

node/src/BaseClient.ts Outdated Show resolved Hide resolved
```
3. After installation, confirm the client is installed by running:
```bash
$ npm list
myApp@ /home/ubuntu/myApp
└── babushka@0.1.0
└── glide-for-redis@0.1.0
```

### Build from source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR: build from source should be in DEVELOPER.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have #703 to do that

csharp/lib/glide.csproj Show resolved Hide resolved
@@ -1,7 +1,7 @@
using System.Diagnostics;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using babushka;
using glide;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, but namespaces should be Capitalized in C#, so - Glide.

csharp/lib/Cargo.toml Show resolved Hide resolved
csharp/lib/Cargo.toml Show resolved Hide resolved
@barshaul barshaul force-pushed the pre_release branch 3 times, most recently from 59b17c3 to 4a85010 Compare December 20, 2023 14:41
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be replaced/renamed by GlideCoreNativeDefinitions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And updated with class rename and lib name
So final class should be

package glide.ffi.resolvers;

public class GlideCoreNativeDefinitions {
  public static native String startSocketListenerExternal() throws Exception;

  public static native Object valueFromPointer(long pointer);

  static {
    System.loadLibrary("glide-rs");
  }

  /**
   * Make an FFI call to obtain the socket path.
   *
   * @return A UDS path.
   */
  public static String getSocket() {
    try {
      return startSocketListenerExternal();
    } catch (Exception | UnsatisfiedLinkError e) {
      System.err.printf("Failed to create a UDS connection: %s%n%n", e);
      throw new RuntimeException(e);
    }
  }
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, was mistakenly saved to another folder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update package in every java source file (first line)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep not sure why it wasn't commited, fixing. thx

@barshaul barshaul force-pushed the pre_release branch 6 times, most recently from 47caa1c to 2178441 Compare December 21, 2023 11:13
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java ok

@barshaul barshaul merged commit 38fc099 into valkey-io:main Dec 21, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants