Skip to content

Commit

Permalink
remove resp3 flow and combine it with run-tests
Browse files Browse the repository at this point in the history
Signed-off-by: ahmedsobeh <[email protected]>
  • Loading branch information
ahmedsobeh committed Aug 5, 2024
1 parent 28ad27b commit 89a0629
Showing 1 changed file with 4 additions and 49 deletions.
53 changes: 4 additions & 49 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ jobs:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.9', 'pypy-3.10']
test-type: ['standalone', 'cluster']
connection-type: ['libvalkey', 'plain']
protocol: ['--protocol=3', '']
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
name: Python ${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}} tests
name: Python ${{ matrix.python-version }} ${{ matrix.protocol }} ${{matrix.test-type}}-${{matrix.connection-type}} tests
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand All @@ -79,9 +80,9 @@ jobs:
fi
invoke devenv
sleep 10 # time to settle
invoke ${{matrix.test-type}}-tests
invoke ${{matrix.test-type}}-tests ${{ matrix.protocol }}
if [[ "${{matrix.python-version}}" != pypy-* ]]; then
invoke ${{matrix.test-type}}-tests --uvloop
invoke ${{matrix.test-type}}-tests --uvloop ${{ matrix.protocol }}
fi
- uses: actions/upload-artifact@v4
Expand All @@ -96,52 +97,6 @@ jobs:
fail_ci_if_error: false
token: ${{ secrets.CODECOV_TOKEN }}


resp3_tests:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.9', 'pypy-3.10']
test-type: ['standalone', 'cluster']
connection-type: ['libvalkey', 'plain']
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
name: RESP3 [${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}}]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
- name: run tests
run: |
pip install -U setuptools wheel
pip install -r requirements.txt
pip install -r dev_requirements.txt
if [ "${{matrix.connection-type}}" == "libvalkey" ]; then
pip install "libvalkey>=4.0.0b1"
fi
invoke devenv
sleep 10 # time to settle
invoke ${{matrix.test-type}}-tests --protocol=3
if [[ "${{matrix.python-version}}" != pypy-* ]]; then
invoke ${{matrix.test-type}}-tests --uvloop --protocol=3
fi
- uses: actions/upload-artifact@v4
if: success() || failure()
with:
name: pytest-results-${{matrix.test-type}}-${{matrix.connection-type}}-${{matrix.python-version}}-resp3
path: '${{matrix.test-type}}*results.xml'

- name: Upload codecov coverage
uses: codecov/codecov-action@v4
with:
fail_ci_if_error: false
token: ${{ secrets.CODECOV_TOKEN }}


build_and_test_package:
name: Validate building and installing the package
runs-on: ubuntu-latest
Expand Down

0 comments on commit 89a0629

Please sign in to comment.