-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hiredis dependency with libvalkey #32
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 75.01% 75.02% +0.01%
==========================================
Files 132 132
Lines 34367 34341 -26
==========================================
- Hits 25782 25766 -16
+ Misses 8585 8575 -10 ☔ View full report in Codecov by Sentry. |
converted to draft until PyPI package for libvalkey-py is published |
hiredis 3.0.0 breaks compatibility with valkey-py. This is just a temporary fix until #32 is ready. Signed-off-by: Salvatore Mesoraca <[email protected]>
hiredis 3.0.0 breaks compatibility with valkey-py. This is just a temporary fix until #32 is ready. Signed-off-by: Salvatore Mesoraca <[email protected]>
hiredis 3.0.0 breaks compatibility with valkey-py. This is just a temporary fix until #32 is ready. Signed-off-by: Salvatore Mesoraca <[email protected]>
hiredis 3.0.0 breaks compatibility with valkey-py. This is just a temporary fix until valkey-io#32 is ready. Signed-off-by: Salvatore Mesoraca <[email protected]>
@mkmkme - I see that both of the constraints you mentioned should be completed now (libvalkey and libvalkey-py are in the valkey org and libvalkey-py has been published to pypi) |
@kjaymiller I still haven't enabled the breaking changes yet, they are behind the flag in |
@kjaymiller JFYI the release I've done was not good enough. I have to release a new one. |
The tests are failing. I know the reason and investigating it |
Signed-off-by: Mikhail Koviazin <[email protected]>
`pip install <pkg>` fails if the only available package version is a beta. `libvalkey 3.0.0` is not suitable for the test and was yanked, `libvalkey 4.0.0b1` is the most recent version. To use it, we need to specify it explicitly. Provide it as a minimum version. Signed-off-by: Mikhail Koviazin <[email protected]>
@aiven-sal @ahmedsobeh all tests are green and Shall we remove the RESP3 libvalkey cluster exclusion as per https://github.com/valkey-io/valkey-py/pull/55/files or will we do this separately? |
There is already a PR for it: #55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
NOTE: This PR should not be merged until
libvalkey-py
is moved intovalkey-io
and the first version oflibvalkey-py
is released to PyPI!Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This changeset changes hiredis dependency with libvalkey.