Skip to content

Commit

Permalink
Fix WAITAOF test in external test due to appendonly is enabled (#775)
Browse files Browse the repository at this point in the history
The test fails because, in external, another test may have
enabled appendonly, causing acklocal to return 1.

We can add a CONFIG SET to disable the appendonly, but this
is not safe too unless we use multi. The test does not actually
rely on appendonly, so we can just * it.

Fixes #770.

Signed-off-by: Binbin <[email protected]>
  • Loading branch information
enjoy-binbin authored Jul 12, 2024
1 parent 9948f07 commit a4ee8da
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tests/unit/scripting.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,9 @@ start_server {tags {"scripting"}} {
run_script {return redis.pcall('wait','1','0')} 0
} {0}

# Temporarily disable test for external until it is stabilized, see https://github.com/valkey-io/valkey/issues/770
test {EVAL - Scripts do not block on waitaof} {
run_script {redis.call('incr', 'x') return redis.pcall('waitaof','0','1','0')} 0
} {0 0} {external:skip}
} {* 0}

test {EVAL - Scripts do not block on XREAD with BLOCK option} {
r del s
Expand Down

0 comments on commit a4ee8da

Please sign in to comment.