Skip to content

Commit

Permalink
Fix storing the wrong PID in active servers (#1464)
Browse files Browse the repository at this point in the history
In #1459, I missed that the data was also used to keep track of the PID
files so if the testing framework crashed it would no longer be able to
cleanup the extra servers. So now we properly extract the PID and store
it so we can clean up PIDs.

Signed-off-by: Madelyn Olson <[email protected]>
  • Loading branch information
madolson authored Dec 20, 2024
1 parent ca0b0c6 commit ffef236
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/test_helper.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,8 @@ proc read_from_test_client fd {
} elseif {$status eq {server-spawning}} {
set ::active_clients_task($fd) "(SPAWNING SERVER) $data"
} elseif {$status eq {server-spawned}} {
lappend ::active_servers $data
set pid [string trim [lindex [split $data "-"] 0]]
lappend ::active_servers $pid
set ::active_clients_task($fd) "(SPAWNED SERVER) pid:$data"
} elseif {$status eq {server-killing}} {
set ::active_clients_task($fd) "(KILLING SERVER) pid:$data"
Expand Down

0 comments on commit ffef236

Please sign in to comment.