replication: fix io-threads possible race by moving waitForClientIO

[uriyage]

Fix race with pending writes in replica state transition

The Problem

In #60 (Dual channel replication) a new connWrite call was added before the waitForClientIO check. This created a race condition where the main thread may attempt to write to a client that could have pending writes in IO threads.

The Fix

Moved the waitForClientIO() call earlier in syncCommand, before any connWrite call. This ensures all pending IO operations are completed before attempting to write to the client.

[ranshid]

@uriyage I am fine with the fix but let's also introduce assertion or debug assertion in connWrite to catch these things.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.83%. Comparing base (789a73b) to head (756c3dc).
Report is 141 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #1422      +/-   ##
============================================
+ Coverage     70.66%   70.83%   +0.16%     
============================================
  Files           114      119       +5     
  Lines         63150    64861    +1711     
============================================
+ Hits          44624    45943    +1319     
- Misses        18526    18918     +392     

Files with missing lines	Coverage Δ
src/replication.c	87.57% <100.00%> (+0.31%)	⬆️
src/socket.c	92.65% <100.00%> (+1.53%)	⬆️

... and 70 files with indirect coverage changes

[uriyage]

@uriyage I am fine with the fix but let's also introduce assertion or debug assertion in connWrite to catch these things.

We need a flag on the connection to indicate that it is a client struct, which will allow us to assert it in connWrite. We will add this flag in PR #1338, and I will add the assertion after that PR is merged.

[uriyage]

@uriyage I am fine with the fix but let's also introduce assertion or debug assertion in connWrite to catch these things.

We need a flag on the connection to indicate that it is a client struct, which will allow us to assert it in connWrite. We will add this flag in PR #1338, and I will add the assertion after that PR is merged.

@ranshid done

[ranshid]

@uriyage . Sorry - can you please rebase this so I can merge later?