Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameter for limiting maximum AOF files size on disk #1425

Closed
wants to merge 101 commits into from

change error message for aox-max-size exceeding

1f3dd5c
Select commit
Loading
Failed to load commit list.
Closed

add parameter for limiting maximum AOF files size on disk #1425

change error message for aox-max-size exceeding
1f3dd5c
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Jan 27, 2025 in 2s

DCO

There are 31 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~101 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin aof_size_limit

Summary

Commit sha: c8e5fc9, Author: Amit Nagler, Committer: kronwerk; Expected "Amit Nagler [email protected]", but got "naglera [email protected]".
Commit sha: 471ecf4, Author: Amit Nagler, Committer: kronwerk; Expected "Amit Nagler [email protected]", but got "naglera [email protected]".
Commit sha: 6281761, Author: Amit Nagler, Committer: kronwerk; Expected "Amit Nagler [email protected]", but got "naglera [email protected]".
Commit sha: 3b08507, Author: eifrah-aws, Committer: kronwerk; Expected "eifrah-aws [email protected]", but got "Eran Ifrah [email protected]".
Commit sha: 2f07b66, Author: gmbnomis, Committer: kronwerk; Expected "gmbnomis [email protected]", but got "Simon Baatz [email protected]".
Commit sha: 890bb71, Author: gmbnomis, Committer: kronwerk; Expected "gmbnomis [email protected]", but got "Simon Baatz [email protected]".
Commit sha: 58482ff, Author: Harkrishn Patro, Committer: kronwerk; Expected "Harkrishn Patro [email protected]", but got "Harkrishn Patro [email protected]".
Commit sha: 1f3dd5c, Author: kronwerk, Committer: kronwerk; The sign-off is missing.
Commit sha: 810a437, Author: Madelyn Olson, Committer: kronwerk; The sign-off is missing.
Commit sha: b4de750, Author: Nadav Gigi, Committer: kronwerk; Expected "Nadav Gigi [email protected]", but got "NadavGigi [email protected]".
Commit sha: 9df9d61, Author: Nadav Gigi, Committer: kronwerk; Expected "Nadav Gigi [email protected]", but got "NadavGigi [email protected]".
Commit sha: 984cb0a, Author: Nikhil Manglore, Committer: kronwerk; Expected "Nikhil Manglore [email protected]", but got "Nikhil Manglore [email protected]".
Commit sha: 2a2900f, Author: Pierre, Committer: kronwerk; Expected "Pierre [email protected]", but got "Pierre Turin [email protected]".
Commit sha: 4f59458, Author: Pierre, Committer: kronwerk; Expected "Pierre [email protected]", but got "Pierre Turin [email protected]".
Commit sha: 91a0918, Author: Pierre, Committer: kronwerk; Expected "Pierre [email protected]", but got "Pierre Turin [email protected]".
Commit sha: 6de3fd5, Author: Pierre, Committer: kronwerk; Expected "Pierre [email protected]", but got "Pierre Turin [email protected]".
Commit sha: f5793d8, Author: ranshid, Committer: kronwerk; Expected "ranshid [email protected]", but got "Ran Shidlansik [email protected]".
Commit sha: 399fb08, Author: ranshid, Committer: kronwerk; Can not find "ranshid [email protected]", in ["ranshid [email protected]", "Ran Shidlansik [email protected]"].
Commit sha: fc20f29, Author: ranshid, Committer: kronwerk; Expected "ranshid [email protected]", but got "Ran Shidlansik [email protected]".
Commit sha: d68667d, Author: ranshid, Committer: kronwerk; Expected "ranshid [email protected]", but got "ranshid [email protected]".
Commit sha: fa97d89, Author: Roshan Khatri, Committer: kronwerk; Expected "Roshan Khatri [email protected]", but got "Roshan Khatri [email protected]".
Commit sha: d76ca02, Author: Roshan Khatri, Committer: kronwerk; Expected "Roshan Khatri [email protected]", but got "Roshan Khatri [email protected]".
Commit sha: 7f0cc83, Author: Roshan Khatri, Committer: kronwerk; Expected "Roshan Khatri [email protected]", but got "Roshan Khatri [email protected]".
Commit sha: c720899, Author: uriyage, Committer: kronwerk; Can not find "uriyage [email protected]", in ["Uri Yagelnik [email protected]", "ranshid [email protected]"].
Commit sha: 3d5acdd, Author: uriyage, Committer: kronwerk; Expected "uriyage [email protected]", but got "Uri Yagelnik [email protected]".
Commit sha: 15189c9, Author: uriyage, Committer: kronwerk; Expected "uriyage [email protected]", but got "Uri Yagelnik [email protected]".
Commit sha: f7ac777, Author: uriyage, Committer: kronwerk; Expected "uriyage [email protected]", but got "Uri Yagelnik [email protected]".
Commit sha: e407ced, Author: Vu Diep, Committer: kronwerk; Expected "Vu Diep [email protected]", but got "vudiep411 [email protected]".
Commit sha: 245f51d, Author: Wen Hui, Committer: kronwerk; Expected "Wen Hui [email protected]", but got "hwware [email protected]".
Commit sha: 4dcb2b7, Author: Wen Hui, Committer: kronwerk; Expected "Wen Hui [email protected]", but got "hwware [email protected]".
Commit sha: bc4f865, Author: xbasel, Committer: kronwerk; Can not find "xbasel [email protected]", in ["Ran Shidlansik [email protected]", "ranshid [email protected]"].