Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client Introspection] Client Commands Extended Filtering #1466

Open
wants to merge 5 commits into
base: unstable
Choose a base branch
from

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Dec 20, 2024

In this PR, we introduce a support for few more filters for CLIENT LIST and CLIENT KILL commands. We introduce these new filters:

  1. SUBSCRIBED-PATTERN pattern the client must subscribe to
  2. SUBSCRIBED-CHANNEL channel the client must subscribe to
  3. SUBSCRIBED-SHARD-CHANNEL <shard channel the client must subscribe to>
  4. FLAGS Client must include this flag. This can be a string with bunch of flags present one after the other.
  5. NAME client name
  6. MIN-IDLE minimum idle time of the client
  7. LIB-NAME clients with the specified lib name.
  8. LIB-VER clients with the specified lib version.
  9. TOT-NET-IN clients with total network input greater than or equal to the specified value
  10. TOT-NET-OUT clients with total network output greater than or equal to the specified value
  11. DB clients currently operating on the specified database ID

Partly Addresses: #668

@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review December 20, 2024 16:59
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the client-extended-filters branch 3 times, most recently from 094ee75 to e518d93 Compare December 20, 2024 19:49
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 66.43357% with 48 lines in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (7fc958d) to head (c843fb9).

Files with missing lines Patch % Lines
src/networking.c 66.43% 48 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1466      +/-   ##
============================================
+ Coverage     70.80%   70.95%   +0.15%     
============================================
  Files           121      121              
  Lines         65132    65271     +139     
============================================
+ Hits          46118    46315     +197     
+ Misses        19014    18956      -58     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)
src/networking.c 87.70% <66.43%> (-1.13%) ⬇️

... and 8 files with indirect coverage changes

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the client-extended-filters branch 4 times, most recently from f7ad3a7 to e3fdff0 Compare January 15, 2025 22:14
@zuiderkwast zuiderkwast added the major-decision-pending Major decision pending by TSC team label Jan 15, 2025
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the client-extended-filters branch 2 times, most recently from 0918a1b to 92f685b Compare January 21, 2025 23:51
Signed-off-by: Sarthak Aggarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-decision-pending Major decision pending by TSC team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants