Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor syncWithPrimary and replicaTryPartialResynchronization #1476

Open
wants to merge 14 commits into
base: unstable
Choose a base branch
from

Merge branch 'valkey-io:unstable' into unstable

447740b
Select commit
Loading
Failed to load commit list.
Open

Refactor syncWithPrimary and replicaTryPartialResynchronization #1476

Merge branch 'valkey-io:unstable' into unstable
447740b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 1s

70.97% (+0.16%) compared to 3032ccd

View this Pull Request on Codecov

70.97% (+0.16%) compared to 3032ccd

Details

Codecov Report

Attention: Patch coverage is 73.07692% with 49 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (3032ccd) to head (447740b).

Files with missing lines Patch % Lines
src/replication.c 73.07% 49 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1476      +/-   ##
============================================
+ Coverage     70.81%   70.97%   +0.16%     
============================================
  Files           121      121              
  Lines         65132    65173      +41     
============================================
+ Hits          46121    46258     +137     
+ Misses        19011    18915      -96     
Files with missing lines Coverage Δ
src/replication.c 87.09% <73.07%> (-0.41%) ⬇️

... and 15 files with indirect coverage changes