Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize one variable in struct to avoid risk #1606

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

hwware
Copy link
Member

@hwware hwware commented Jan 23, 2025

In C, we had better initialize every variable in struct, this PR fixes one missed variable Initialization.

@hwware hwware force-pushed the initial-failover-auth-sent branch from f481dd5 to 293825c Compare January 23, 2025 22:06
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.84%. Comparing base (f251078) to head (16193dd).
Report is 10 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1606      +/-   ##
============================================
- Coverage     71.00%   70.84%   -0.16%     
============================================
  Files           121      121              
  Lines         65139    65175      +36     
============================================
- Hits          46249    46175      -74     
- Misses        18890    19000     +110     
Files with missing lines Coverage Δ
src/cluster_legacy.c 87.23% <100.00%> (+0.06%) ⬆️

... and 19 files with indirect coverage changes

Copy link
Member

@enjoy-binbin enjoy-binbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move it near the failover_auth_rank

@hwware hwware force-pushed the initial-failover-auth-sent branch from 6c68cf0 to 16193dd Compare January 28, 2025 16:08
@hwware
Copy link
Member Author

hwware commented Jan 28, 2025

let's move it near the failover_auth_rank

Addressed. Thanks

@hwware hwware merged commit ad60d6b into valkey-io:unstable Jan 28, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants