Make sure to disable pause after fork for dual channel test #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <[email protected]>
zuiderkwast
added
the
run-extra-tests
|
@zuiderkwast FYI, run extra tests doesn't run valgrind since they take like 2 hours. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1612 +/- ##
============================================
+ Coverage 70.82% 70.97% +0.15%
============================================
Files 120 121 +1
Lines 64911 65169 +258
============================================
+ Hits 45972 46256 +284
+ Misses 18939 18913 -26 |
ranshid
reviewed
Jan 24, 2025
madolson
changed the title
zuiderkwast
removed
the
run-extra-tests
naglera
reviewed
Jan 26, 2025
Signed-off-by: Madelyn Olson <[email protected]>
ranshid
approved these changes
Jan 26, 2025
naglera
approved these changes
Jan 26, 2025
zuiderkwast
approved these changes
Jan 26, 2025
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Feb 1, 2025
…o#1612) Might close valkey-io#1484. I noticed that we don't disable pause after fork on the last test that was getting executed, so it might getting stuck in pause loops after the test ends if it tries another psync for any reason. --------- Signed-off-by: Madelyn Olson <[email protected]> Signed-off-by: Harkrishn Patro <[email protected]>
enjoy-binbin
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Feb 2, 2025
…o#1612) Might close valkey-io#1484. I noticed that we don't disable pause after fork on the last test that was getting executed, so it might getting stuck in pause loops after the test ends if it tries another psync for any reason. --------- Signed-off-by: Madelyn Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might close #1484.
I noticed that we don't disable pause after fork on the last test that was getting executed, so it might getting stuck in pause loops after the test ends if it tries another psync for any reason.