Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update daily failure notification job list #1648

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

hpatro
Copy link
Collaborator

@hpatro hpatro commented Jan 30, 2025

Two jobs were missing from the job list for failure notification

  • test-ubuntu-tls-io-threads
  • test-sanitizer-force-defrag

@hpatro
Copy link
Collaborator Author

hpatro commented Jan 30, 2025

We should possibly move to list the jobs dynamically rather than depending on the hardcoded list.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.98%. Comparing base (12ec3d5) to head (a0fd944).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #1648   +/-   ##
=========================================
  Coverage     70.98%   70.98%           
=========================================
  Files           121      121           
  Lines         65176    65176           
=========================================
+ Hits          46264    46268    +4     
+ Misses        18912    18908    -4     

see 9 files with indirect coverage changes

@hpatro hpatro requested a review from zuiderkwast January 30, 2025 22:52
@zuiderkwast
Copy link
Contributor

zuiderkwast commented Jan 30, 2025

We should possibly move to list the jobs dynamically rather than depending on the hardcoded list.

Yeah... But that seems more difficult. :)

@hpatro
Copy link
Collaborator Author

hpatro commented Jan 30, 2025

We should possibly move to list the jobs dynamically rather than depending on the hardcoded list.

Yeah... But that seems more difficult. :)

Yep, couldn't find an easier way immediately.

@hpatro hpatro merged commit 78bcc0a into valkey-io:unstable Jan 30, 2025
49 checks passed
enjoy-binbin pushed a commit to enjoy-binbin/valkey that referenced this pull request Feb 2, 2025
Two jobs were missing from the job list for failure notification

* test-ubuntu-tls-io-threads
* test-sanitizer-force-defrag

Signed-off-by: Harkrishn Patro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants