-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow TCL 9.0 for tests #1673
base: unstable
Are you sure you want to change the base?
Allow TCL 9.0 for tests #1673
Conversation
Signed-off-by: Viktor Söderqvist <[email protected]>
Fedora now comes with TCL 9.0 and we started getting failures like this: https://github.com/valkey-io/valkey/actions/runs/13147311114/job/36688160501 |
Signed-off-by: Viktor Söderqvist <[email protected]>
Which version is used in our online CI? |
Signed-off-by: Viktor Söderqvist <[email protected]>
Most of them have 8.6. Macos has 8.5. Fedora rawhide has now only 9.0. I guess we need to support all of them. |
TCL 9.0 works now. The test-fedorarawhide-jemalloc job passed. The remaining failures are other problems. One of them is solved in #1675. |
😱 Still fails with TLS:
Need to solve this too. |
Signed-off-by: Viktor Söderqvist <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1673 +/- ##
============================================
+ Coverage 71.05% 71.06% +0.01%
============================================
Files 121 121
Lines 65243 65243
============================================
+ Hits 46357 46365 +8
+ Misses 18886 18878 -8 |
😓 The TCL TLS package doesn't seem to support TCL 9.0 yet. See here: https://core.tcl-lang.org/tcltls/wiki/Documentation There's a beta version of this package 2.0 which will support TCL 9.0 according to this page: https://core.tcl-lang.org/tcltls/file?name=doc/tls.html&ci=trunk Currently, fedora rawhide includes tcltls 1.7 which is incompatible with tcl 9.0 and effectively broken. I guess they will fix it soon. Alternatives to this PR:
|
i think we can go with this option. |
@@ -294,7 +292,7 @@ proc parse_options {} { | |||
incr j | |||
set ::host ${val} | |||
} elseif {$opt eq {--tls} || $opt eq {--tls-module}} { | |||
package require tls 1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not touch tls lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tls 1.6 requires TCL 8.x and it rejects TCL 9.x.
If we want to use TCL 9.0, we need to use tls 2.0, which is only a beta version now. It's not yet released.
If we want to allow different TCL versions, we also need different TLS lib versions, so I think we can remove the hard-coded version requirements.
I think having it here is good as it notifies us about upcoming issues, but I agree for the moment we shouldn't be blocked on it. |
@jonathanspw is looking at solving this in Fedora, probably add TCL 8 back. |
Add 9.0 to list of allowed TCL versions for running the tests.
8.7 is removed. There is no such TCL version. I guess 8.7 was added in the past as an attempt to be future proof.