Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure dataset version is all lowercase #6

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

drazendee
Copy link
Contributor

Make sure we lower the project name because:

Dataset Version name must be lowercase, start with a letter or number and may contain letters, numbers, dashes, dots, and underscores thereafter.

Make sure we lower the project name because:

> Dataset Version name must be lowercase, start with a letter or number and may contain letters, numbers, dashes, dots, and underscores thereafter.
@drazendee drazendee requested review from ruksi, a team, noorula and SofiaChar and removed request for a team August 23, 2024 12:19
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes the get_run_identification to returns lowercased project name; the name is used in the dataset URI generation

@ruksi ruksi merged commit 6436622 into main Aug 26, 2024
1 check passed
@ruksi ruksi deleted the lower-project-name branch August 26, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants