Name ecommerce.items parameter names in purchase event GA4-compliant #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aracter_U+20AC' into rel_2.x
taken from pull-request; thank you C. Stäblein
# Conflicts: # CHANGELOG.md # metadata.php
accidentally the existing settings were overwritten
accidentally the existing settings were overwritten
…_2.x_fix_onactivate # Conflicts: # Setup/Actions.php
classify PHP and OXID-CE-Version
Activating the Module on CLI happens so early, there's no ModuleChain available yet, therefor no extension, therefor no additional methods
…ev_2.x_12787_bug_fixing
…ontroller\d3GtmStartController is not an instance of OxidEsales\Eshop\Application\Component\Widget\WidgetController"
- new block extension - new template for the event-data for GA - metadata adjustments for it - new version ( 2.20.0 )
- add Payment-Model extension for own small method - new block extension - new template for the event-data for GA - metadata adjustments for it
…ller' into rel_2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of the items parameter names in the purchase event are not named GA4 compliant. (https://github.com/d3datadevelopment/GoogleAnalytics4/blob/master/Application/views/blocks/checkout_s5.tpl)
So they are called "id, name, variant", although they should be called "item_id, item_name, item_variant". (See https://developers.google.com/analytics/devguides/collection/ga4/set-up-ecommerce?hl=de#add-event)
In the view_item, add_to_cart and view_cart event they are named correctly.