Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Valkey engine pricing data for Elasticache #757

Merged
merged 1 commit into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions detail_pages_cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
cache_engine_mapping = {
"Memcached": "Memcached",
"Redis": "Redis",
"Valkey": "Valkey",
}


Expand Down
4 changes: 2 additions & 2 deletions in/cache.html.mako
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
<abbr title="Each virtual CPU is a hyperthread of an Intel Xeon core for M3, C4, C3, R3, HS1, G2, I2, and D2">vCPUs</abbr>
</th>
<th class="networkperf">Network Performance</th>
% for cache_engine in {'Redis', 'Memcached'}:
% for cache_engine in {'Redis', 'Memcached', 'Valkey'}:
% if cache_engine == 'Redis':
<th class="cost-ondemand cost-ondemand-${cache_engine} all" data-priority="1">${cache_engine} Cost</th>
% else:
Expand Down Expand Up @@ -171,7 +171,7 @@
${inst['network_performance']}
</span>
</td>
% for cache_engine in {'Redis', 'Memcached'}:
% for cache_engine in {'Redis', 'Memcached', 'Valkey'}:
<td class="cost-ondemand cost-ondemand-${cache_engine}" data-platform='${cache_engine}' data-vcpu='${inst['vcpu']}' data-memory='${inst['memory']}'>
% if inst['pricing'].get('us-east-1', {}).get(cache_engine, {}).get('ondemand', 'N/A') != "N/A":
<span sort="${inst['pricing']['us-east-1'][cache_engine]['ondemand']}">
Expand Down
3 changes: 2 additions & 1 deletion in/instance-type-cache.html.mako
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@
<div class="col-6 mb-2">
<select class="form-select form-select-sm" id="os">
<option value="Redis">Redis</option>
<option value="Memcached">Memcached</option>
<option value="Memcached">Memcached</option>
<option value="Valkey">Valkey</option>
</select>
</div>
<div class="col-6 pe-2">
Expand Down
Loading