Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update tests #87

Merged
merged 3 commits into from
Jan 31, 2025
Merged

chore: Update tests #87

merged 3 commits into from
Jan 31, 2025

Conversation

mjcorwin
Copy link
Contributor

@mjcorwin mjcorwin commented Jan 23, 2025

  • Verifies team token usage for access grants
  • Updates workspace data source test to check that at least one workspace is returned

Related to:
https://github.com/vantage-sh/core/pull/11244

Verifies team token usage for access grants
Copy link
Contributor

@whereandy whereandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test looks good, but I think a more relevant test that verifies https://github.com/vantage-sh/core/pull/11244 would be to attempt a test suite run using a Team-based API token.

@mjcorwin mjcorwin changed the title chore: Add test for creating a resource access grant. chore: Update tests Jan 31, 2025
@mjcorwin mjcorwin requested a review from whereandy January 31, 2025 01:18
@mjcorwin
Copy link
Contributor Author

Re-requesting review.

Updated workspace test to not rely on a workspace named "Default" since that is not always the case.

@mjcorwin mjcorwin merged commit a57d864 into main Jan 31, 2025
@mjcorwin mjcorwin deleted the mjcorwin/access_grant_resource_test branch January 31, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants