Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to create service account #185

Merged
merged 2 commits into from
May 29, 2020
Merged

Added ability to create service account #185

merged 2 commits into from
May 29, 2020

Conversation

danquack
Copy link
Contributor

@danquack danquack commented May 29, 2020

FYI - @edaniszewski Relates to #176

@danquack danquack changed the title ✨ Added ability to create service account Added ability to create service account May 29, 2020
Copy link
Contributor

@edaniszewski edaniszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! (: I think it largely looks good, but just had a note in one place for an object type that I think needs to be updated.

kubetest/objects/serviceaccount.py Outdated Show resolved Hide resolved
@danquack
Copy link
Contributor Author

danquack commented May 29, 2020

BTW I totally love this idea of making it a part of pytest. This is an awesome repo! Is there anything i need to update docs, or do they do that automagically?

@danquack danquack requested a review from edaniszewski May 29, 2020 14:33
@edaniszewski
Copy link
Contributor

Thanks! And thanks again for the contribution and for going through and doing all the docstring updates.. I know it can be a bit tedious. Nothing for you to do with docs - they should be rebuilt automagically on release (:

@edaniszewski edaniszewski merged commit 1cb068a into vapor-ware:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants