Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Src layout #1087

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Src layout #1087

merged 8 commits into from
Aug 14, 2024

Conversation

woutdenolf
Copy link
Collaborator

@woutdenolf woutdenolf commented Aug 14, 2024

Closes #1086

bootstrap.py is not needed anymore so I guess we can remove it as well.

@vasole
Copy link
Owner

vasole commented Aug 14, 2024

Why are you stating numpy < 2 in CONTRIBUTING.md?

Is it possible to stick to rst instead of markdown?

@woutdenolf
Copy link
Collaborator Author

woutdenolf commented Aug 14, 2024

Because I branched of the master branch from more than a year ago by mistake. Rebased and converted md to rst.

@woutdenolf woutdenolf requested a review from vasole August 14, 2024 10:08
@woutdenolf
Copy link
Collaborator Author

I forgot the MANIFEST.in file as well.

@vasole
Copy link
Owner

vasole commented Aug 14, 2024

Line 267 in setup.py needs to be corrected.

setup.py Outdated Show resolved Hide resolved
@vasole
Copy link
Owner

vasole commented Aug 14, 2024

The https://gitlab.esrf.fr/silx/bob/PyMca5 and https://gitlab.esrf.fr/silx/bob/pymca-dmg pipelines will need to be tested too.

They are used to generate wheels and frozen binaries.

@vasole vasole merged commit 6742fc1 into vasole:master Aug 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap no longer working?
2 participants