Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when hovering at the edge of the globe #42

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

olaszakos
Copy link
Contributor

@olaszakos olaszakos commented Apr 26, 2021

Hi, and thank you for this awesome library!

I ran into the same issue as the guys here: vasturiano/react-globe.gl#46

I found that this is due to a missing null check.

Steps to reproduce the issue (at least on Chrome, Mac):

  1. open for instance the basic example https://globe.gl/example/basic/
  2. open the JS console to see the error
  3. start hovering at the edge of the globe, where the atmosphere and Earth meet
  4. you get the error which stops further event processing (the globe "locks up")

This pull request adds the null check.

@vasturiano vasturiano merged commit 20da5e8 into vasturiano:master Apr 26, 2021
@vasturiano
Copy link
Owner

Thanks @olaszakos for your fix! Indeed there was a missing null check there. I've adjusted the condition slightly, but the outcome is the same as in your code. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants