Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to 1.0 #6

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Updated to 1.0 #6

wants to merge 15 commits into from

Conversation

Jdalt40
Copy link

@Jdalt40 Jdalt40 commented Jul 16, 2018

No description provided.

@vasumahesh1
Copy link
Owner

Hi,

Sorry I have been MIA on this mod for a while. I can test these changes this weekend and merge this request.

Thanks for contributing, I have been having issues finding time for this! I will update you on Saturday/Sunday!

@Jdalt40
Copy link
Author

Jdalt40 commented Aug 7, 2018

No probs! Feel free to tamper with anything you find wrong, I did work on things a bit to make sure it worked fine.

@vasumahesh1
Copy link
Owner

vasumahesh1 commented Aug 13, 2018

Hi,

I was unable to test it for the unstable branch. Ran into some errors as I believe these changes are for 1964 and the Steam one I launched was 1978 or something.

Not sure if I need a custom HugsLib for unstable branches. Would be great if you could give me some steps on how to run this correctly! :)

Couple of things in this PR though:

  1. Might not want to remove the *.ase files, These files are the actual files where the texture is made
  2. Also, the Elixir (anything with ex) files. These are build files that help me zip the mod with the bare minimum required files
  3. You could keep the Forum Text text files (Steam's text editor for the workshop was crappy, so I often edit it on Sublime)

If you are worried about the mod containing the useless files, they aren't actually zipped with it.

I basically run mix zip_mod and it cherry picks the folders I need to publish a release. (Also, the version is inside the elixir files which is used to create the zip's name)

Also, forgot to mention:
Add your name under the contributor & a link preferably (in the forum text & workshop text). I will copy and replace the text on Steam workshop & other places using that file. 👍

Once again, Many thanks for this PR. Once RimWorld reaches 1.0 stable, we can then release this mod.

@Jdalt40
Copy link
Author

Jdalt40 commented Aug 13, 2018

Hey vasumahesh1, I haven’t experienced the errors on my end, however I’ll do a check for them in a few hours by replacing my local copy with the Github copy. There’s a possibility that there was an error that was present in the Github version but not present in my local copy. All the other files I’ll bring back when I have time. Have a good day :)

@vasumahesh1
Copy link
Owner

vasumahesh1 commented Aug 13, 2018

Sure thing. I basically downloaded your master branch and tested it out. Let me know when they are synced (your master branch and the local copy).

Regarding the older files: You can download the repo as a zip and copy over the Misc folder I believe :)

Also, saw a few Debug/ folder that slipped through in the PR.

Thanks!

@vasumahesh1
Copy link
Owner

Hey, Sorry for the late update. But I managed to update the mod for B19 thanks to this Pull Request.

I have added your link in the contributors for this mod. I think we should keep this PR open and you could update the mod to v1.0 stable when RimWorld is out.

Thanks!

@Jdalt40
Copy link
Author

Jdalt40 commented Sep 1, 2018

Sure, I'll see what I can do vasumahesh, good work on this mod! It's funny because I was slamming my head against a desk for 3 hours on a simple XML error when Mehni pointed out that one field that you were using () had to be put under the building node because Tynan changed that.
Such a stupid field change but it broke everything for 3 hours lol.
Anyway have an amazing day and hopefully everything works fine, I recommend doing a double check over my changes as your mod was my second/third C# mod I've ported over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants