-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to 1.0 #6
base: master
Are you sure you want to change the base?
Conversation
Hi, Sorry I have been MIA on this mod for a while. I can test these changes this weekend and merge this request. Thanks for contributing, I have been having issues finding time for this! I will update you on Saturday/Sunday! |
No probs! Feel free to tamper with anything you find wrong, I did work on things a bit to make sure it worked fine. |
Hi, I was unable to test it for the unstable branch. Ran into some errors as I believe these changes are for 1964 and the Steam one I launched was 1978 or something. Not sure if I need a custom HugsLib for unstable branches. Would be great if you could give me some steps on how to run this correctly! :) Couple of things in this PR though:
If you are worried about the mod containing the useless files, they aren't actually zipped with it. I basically run Also, forgot to mention: Once again, Many thanks for this PR. Once RimWorld reaches 1.0 stable, we can then release this mod. |
Hey vasumahesh1, I haven’t experienced the errors on my end, however I’ll do a check for them in a few hours by replacing my local copy with the Github copy. There’s a possibility that there was an error that was present in the Github version but not present in my local copy. All the other files I’ll bring back when I have time. Have a good day :) |
Sure thing. I basically downloaded your master branch and tested it out. Let me know when they are synced (your master branch and the local copy). Regarding the older files: You can download the repo as a zip and copy over the Also, saw a few Debug/ folder that slipped through in the PR. Thanks! |
Hey, Sorry for the late update. But I managed to update the mod for B19 thanks to this Pull Request. I have added your link in the contributors for this mod. I think we should keep this PR open and you could update the mod to v1.0 stable when RimWorld is out. Thanks! |
Sure, I'll see what I can do vasumahesh, good work on this mod! It's funny because I was slamming my head against a desk for 3 hours on a simple XML error when Mehni pointed out that one field that you were using () had to be put under the building node because Tynan changed that. |
No description provided.