Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-core): add loading state on console #8226

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

S3bastianCZ
Copy link
Contributor

Description

Add a loading state to console window, much visible with a 3G throttling

Screenshot

Capture d’écran 2025-01-08 à 11 02 52 (2)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add an entry in CHANGELOG.unreleased.md

@MathieuRA MathieuRA requested a review from J0ris-K January 8, 2025 15:04
@S3bastianCZ S3bastianCZ requested a review from J0ris-K January 9, 2025 08:58
CHANGELOG.unreleased.md Show resolved Hide resolved
@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 9, 2025 10:12
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 9, 2025 13:28
@MathieuRA MathieuRA merged commit 3a21290 into master Jan 9, 2025
1 check passed
@MathieuRA MathieuRA deleted the loading-state-on-console branch January 9, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants