Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-core): focus on console #8235

Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat(web-core): focus on console #8235

merged 2 commits into from
Jan 22, 2025

Conversation

S3bastianCZ
Copy link
Contributor

@S3bastianCZ S3bastianCZ commented Jan 9, 2025

Description

Adding a border when the console is focused

Screenshot

Capture d’écran 2025-01-09 à 13 53 16

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@S3bastianCZ S3bastianCZ self-assigned this Jan 9, 2025
@S3bastianCZ S3bastianCZ changed the title feat(web-core):focus on console feat(web-core): focus on console Jan 9, 2025
@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 9, 2025 12:54
@MathieuRA MathieuRA requested review from J0ris-K and removed request for MathieuRA January 9, 2025 13:30
@S3bastianCZ S3bastianCZ force-pushed the focus-on-console branch 2 times, most recently from 324105a to 53f525e Compare January 9, 2025 14:10
@S3bastianCZ S3bastianCZ requested review from MathieuRA and removed request for J0ris-K January 20, 2025 07:44
@MathieuRA MathieuRA requested a review from J0ris-K January 20, 2025 09:41
@S3bastianCZ S3bastianCZ force-pushed the focus-on-console branch 2 times, most recently from 3652351 to e609340 Compare January 20, 2025 10:06
@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 20, 2025 10:07
@S3bastianCZ S3bastianCZ force-pushed the focus-on-console branch 3 times, most recently from 1a7d8a8 to 7e45695 Compare January 20, 2025 14:20
@S3bastianCZ S3bastianCZ requested a review from J0ris-K January 20, 2025 14:20
@MathieuRA MathieuRA merged commit 300bb18 into master Jan 22, 2025
1 check passed
@MathieuRA MathieuRA deleted the focus-on-console branch January 22, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants