-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xo-6): add console fullscreen action #8238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3bastianCZ
force-pushed
the
console-fullscreen-action
branch
2 times, most recently
from
January 20, 2025 13:30
df40590
to
e576114
Compare
S3bastianCZ
force-pushed
the
console-fullscreen-action
branch
2 times, most recently
from
January 20, 2025 14:29
1922d70
to
a2343b0
Compare
OlivierFL
requested changes
Jan 21, 2025
@xen-orchestra/web-core/lib/components/console/VtsActionsConsole.vue
Outdated
Show resolved
Hide resolved
@xen-orchestra/web-core/lib/components/console/VtsRemoteConsole.vue
Outdated
Show resolved
Hide resolved
S3bastianCZ
force-pushed
the
console-fullscreen-action
branch
2 times, most recently
from
January 21, 2025 10:59
d0bdbc9
to
7106a31
Compare
MathieuRA
requested changes
Jan 21, 2025
S3bastianCZ
force-pushed
the
console-fullscreen-action
branch
from
January 21, 2025 15:23
7106a31
to
a6ad9cd
Compare
OlivierFL
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things I didn't notice on my first review:
- The same logic is duplicated across the views/pages in XO 6 and XO Lite. I think it would be better to refactor the functions in the
VtsRemoteConsole
component, and expose them withdefineExpose
, likesendCtrlAltDel()
- In
@xen-orchestra/lite/src/views/vm/VmConsoleView.vue
, there is another functionality implemented: the "escape key" behavior that allows the user to press "escape" key to exit fullscreen mode. I think that this feature should also be handled in all consoles. What do you think? /cc @MathieuRA
S3bastianCZ
force-pushed
the
console-fullscreen-action
branch
from
January 22, 2025 08:20
a6ad9cd
to
6daa538
Compare
S3bastianCZ
force-pushed
the
console-fullscreen-action
branch
3 times, most recently
from
January 22, 2025 14:16
63cb409
to
ed19238
Compare
S3bastianCZ
force-pushed
the
console-fullscreen-action
branch
from
January 22, 2025 14:38
ed19238
to
bbc1918
Compare
OlivierFL
approved these changes
Jan 23, 2025
MathieuRA
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add fullscreen functionality for Xo6 console
Screenshot
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: