Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-6): add console fullscreen action #8238

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

S3bastianCZ
Copy link
Contributor

Description

Add fullscreen functionality for Xo6 console

Screenshot

Capture d’écran 2025-01-10 à 14 24 06

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 10, 2025 13:26
@S3bastianCZ S3bastianCZ self-assigned this Jan 10, 2025
MathieuRA

This comment was marked as resolved.

@MathieuRA MathieuRA requested a review from OlivierFL January 16, 2025 10:29
@S3bastianCZ S3bastianCZ force-pushed the console-fullscreen-action branch 2 times, most recently from df40590 to e576114 Compare January 20, 2025 13:30
@S3bastianCZ S3bastianCZ requested a review from MathieuRA January 20, 2025 13:33
@S3bastianCZ S3bastianCZ force-pushed the console-fullscreen-action branch 2 times, most recently from 1922d70 to a2343b0 Compare January 20, 2025 14:29
@S3bastianCZ S3bastianCZ force-pushed the console-fullscreen-action branch 2 times, most recently from d0bdbc9 to 7106a31 Compare January 21, 2025 10:59
@S3bastianCZ S3bastianCZ requested a review from OlivierFL January 21, 2025 11:00
@S3bastianCZ S3bastianCZ force-pushed the console-fullscreen-action branch from 7106a31 to a6ad9cd Compare January 21, 2025 15:23
Copy link
Collaborator

@OlivierFL OlivierFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I didn't notice on my first review:

  • The same logic is duplicated across the views/pages in XO 6 and XO Lite. I think it would be better to refactor the functions in the VtsRemoteConsole component, and expose them with defineExpose, like sendCtrlAltDel()
  • In @xen-orchestra/lite/src/views/vm/VmConsoleView.vue, there is another functionality implemented: the "escape key" behavior that allows the user to press "escape" key to exit fullscreen mode. I think that this feature should also be handled in all consoles. What do you think? /cc @MathieuRA

@S3bastianCZ S3bastianCZ force-pushed the console-fullscreen-action branch from a6ad9cd to 6daa538 Compare January 22, 2025 08:20
@S3bastianCZ S3bastianCZ force-pushed the console-fullscreen-action branch 3 times, most recently from 63cb409 to ed19238 Compare January 22, 2025 14:16
@S3bastianCZ S3bastianCZ force-pushed the console-fullscreen-action branch from ed19238 to bbc1918 Compare January 22, 2025 14:38
@MathieuRA MathieuRA merged commit 1f4ec8d into master Jan 23, 2025
1 check passed
@MathieuRA MathieuRA deleted the console-fullscreen-action branch January 23, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants