Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thorhead to App Hub #310

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add Thorhead to App Hub #310

merged 2 commits into from
Jan 16, 2025

Conversation

kyleboe
Copy link
Contributor

@kyleboe kyleboe commented Jan 4, 2025

An ERC-721 NFT project that costs 100VTHO to randomly generate a Thorhead NFT from a pool of increasingly rare attributes.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 9, 2025

@libotony you had the chance to look at this? anything need changing?

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 12, 2025

I'm not sure why CI says it is failing. The address is accessible. https://vechainstats.com/account/0x24ee6e8d0ffcca3d73eada5c8585301f2bc10d60/

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 12, 2025

Ahhh I see now, the contract address cannot be the checksum version of the address. 🤦

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 14, 2025

@libotony the issue withe CI should be resolved now.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 15, 2025

@libotony with this error, I am doubting everything I know.

Validation failed: please submit only one app at a time

@libotony
Copy link
Member

@kyleboe Could you do a rebase of the master branch?

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 15, 2025

Rebased and squashed. Hopefully that fixes things.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 16, 2025

@libotony I ran the validation script locally and it passed. I also ran the git diff section and it only shows the two files.

@libotony libotony merged commit 6753001 into vechain:master Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants