move bn256,blake2b to upstream, sync with ethereum/go-etherum v1.13.11 #41
libotonyAnnotations
10 errors and 3 warnings
|
golangci-lint:
vm/jump_table.go#L182
Function 'NewFrontierInstructionSet' is too long (680 > 60) (funlen)
|
|
golangci-lint:
vm/contracts.go#L352
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
golangci-lint:
vm/contracts.go#L406
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
golangci-lint:
runtime/runtime.go#L108
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
golangci-lint:
vm/contracts.go#L287
Comment should end in a period (godot)
|
|
golangci-lint:
vm/instructions.go#L799
Comment should end in a period (godot)
|
|
golangci-lint:
vm/instructions.go#L806
Comment should end in a period (godot)
|
|
golangci-lint:
thor/fork_config.go#L22
don't use ALL_CAPS in Go names; use CamelCase (golint)
|
|
golangci-lint:
go.mod#L62
replacement are not allowed: github.com/ethereum/go-ethereum (gomoddirectives)
|
|
golangci-lint:
vm/evm.go#L188
line is 149 characters (lll)
|
|
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
golangci-lint:
vm/instructions.go#L800
unused-parameter: parameter 'pc' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci-lint:
vm/instructions.go#L807
unused-parameter: parameter 'pc' seems to be unused, consider removing or renaming it as _ (revive)
|