Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak golangci-lint conf #663

Merged
merged 2 commits into from
Feb 1, 2024
Merged

tweak golangci-lint conf #663

merged 2 commits into from
Feb 1, 2024

Conversation

libotony
Copy link
Member

@libotony libotony commented Jan 30, 2024

Description

This PR implicitly declared a list of initial linters for golangci-lint, copied from go-ethereum. Requires #662

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@libotony libotony changed the title Lint conf tweak golangci-lint conf Jan 30, 2024
@libotony
Copy link
Member Author

libotony commented Jan 30, 2024

@darrenvechain please take a look next step would be lint test files as well

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a66f5ff) 51.99% compared to head (167d73f) 51.98%.

Files Patch % Lines
api/events/types.go 0.00% 9 Missing ⚠️
runtime/runtime.go 33.33% 2 Missing ⚠️
bft/engine.go 0.00% 1 Missing ⚠️
consensus/validator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage   51.99%   51.98%   -0.02%     
==========================================
  Files         156      156              
  Lines       17239    17218      -21     
==========================================
- Hits         8963     8950      -13     
+ Misses       7453     7445       -8     
  Partials      823      823              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony libotony marked this pull request as ready for review February 1, 2024 02:43
@libotony libotony requested a review from a team as a code owner February 1, 2024 02:43
@libotony libotony merged commit 42d76bb into vechain:master Feb 1, 2024
10 checks passed
@libotony libotony deleted the lint-conf branch February 1, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants