Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-add subscription test #763

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

paologalligit
Copy link
Member

Description

This PR reintroduce the pending subscription test previously deleted because flaky.

Fixes # issue-214

Type of change

  • Add new test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.70%. Comparing base (27e60e6) to head (706858b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
+ Coverage   62.59%   62.70%   +0.10%     
==========================================
  Files         199      199              
  Lines       18093    18093              
==========================================
+ Hits        11326    11345      +19     
+ Misses       5685     5664      -21     
- Partials     1082     1084       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paologalligit paologalligit marked this pull request as ready for review May 28, 2024 11:06
@paologalligit paologalligit requested a review from a team as a code owner May 28, 2024 11:06
@libotony libotony merged commit d0670b8 into vechain:master Jun 6, 2024
14 checks passed
@paologalligit paologalligit deleted the sub-fix-flaky-test branch September 6, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants