Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow injection of master key via stdin #772

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

darrenvechain
Copy link
Member

Description

allow injection of master key via stdin

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Run:

echo "842497a1c69577f4be27ae2ec64751a0c0165f9011e6c27570e21f48c4af9d50" | ./bin/thor --network=main --master-key-stdin

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner June 10, 2024 12:20
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 62.53%. Comparing base (3d7ab12) to head (fead0f4).
Report is 1 commits behind head on master.

Files Patch % Lines
cmd/thor/utils.go 0.00% 30 Missing ⚠️
cmd/thor/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   62.58%   62.53%   -0.05%     
==========================================
  Files         199      199              
  Lines       18098    18142      +44     
==========================================
+ Hits        11326    11346      +20     
- Misses       5690     5714      +24     
  Partials     1082     1082              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

otherview
otherview previously approved these changes Jun 14, 2024
@libotony
Copy link
Member

@darrenvechain Made a small improvement, use the existing password input func when it's in terminal mode, check this commit

@otherview otherview merged commit dfabf13 into vechain:master Jun 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants